fix(span/estree): skip ModuleKind::Unambiguous varient for estree

[Dunqing]

close: #10139

The ModuleKind::Unambiguous can only occur in the parser stage, after being parsed, the ModuleKind certainly changes to ModuleKind::Script or ModuleKind::Module; otherwise is a bug in the parser.

[Dunqing]

• fix(span/estree): skip ModuleKind::Unambiguous varient for estree #10146 👈 (View in Graphite)
• feat(ast_tools): support #[estree(skip)] for enum varient #10145
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10146 will degrade performances by 3.76%

_{Comparing 03-31-fix_span_estree_skip_modulekind_unambiguous_varient_for_estree (52f2a40) with main (06fc07c)}

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	formatter[antd.js]	7.6 ms	7.9 ms	-3.76%
⚡	formatter[typescript.js]	7.4 ms	7.2 ms	+3.41%

[overlookmotel]

Personally, I'd prefer it if we had a separate ParserSourceType which is used in parser options, and the SourceType used in AST didn't have the "Unambiguous" variant at all - so you can't create an AST with this erroneous source type which will panic when serialized.

But for now, yes, this seems like the best solution.

[overlookmotel]

Merge activity

• Apr 3, 12:41 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 3, 12:51 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Apr 3, 12:54 PM EDT: Merged by the Graphite merge queue.

[overlookmotel]

Ah it seems I suggested the separate SourceType idea before: #6249.