Skip to content

feat(ast_tools): support #[estree(skip)] for enum varient#10145

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-31-feat_ast_tools_support_estree_skip_for_enum_varient
Apr 3, 2025
Merged

feat(ast_tools): support #[estree(skip)] for enum varient#10145
graphite-app[bot] merged 1 commit intomainfrom
03-31-feat_ast_tools_support_estree_skip_for_enum_varient

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 31, 2025

Part of #10139

#[estree(skip)] has been supported for struct field. This PR supports the enum variant.

Copy link
Member Author

Dunqing commented Mar 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review March 31, 2025 07:29
@Dunqing Dunqing requested a review from overlookmotel as a code owner March 31, 2025 07:29
@github-actions github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Mar 31, 2025
@Dunqing Dunqing force-pushed the 03-31-feat_ast_tools_support_estree_skip_for_enum_varient branch from b95efce to c15181f Compare March 31, 2025 07:36
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Instrumentation Performance Report

Merging #10145 will not alter performance

Comparing 03-31-feat_ast_tools_support_estree_skip_for_enum_varient (b95efce) with main (962f3ba)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 03-31-feat_ast_tools_support_estree_skip_for_enum_varient branch 2 times, most recently from e5d2337 to e780138 Compare April 3, 2025 16:37
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 3, 2025
Copy link
Member

overlookmotel commented Apr 3, 2025

Merge activity

Part of #10139

`#[estree(skip)]` has been supported for struct field. This PR supports the enum variant.
@graphite-app graphite-app bot force-pushed the 03-31-feat_ast_tools_support_estree_skip_for_enum_varient branch from e780138 to 55b7b87 Compare April 3, 2025 16:47
@graphite-app graphite-app bot merged commit 55b7b87 into main Apr 3, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 03-31-feat_ast_tools_support_estree_skip_for_enum_varient branch April 3, 2025 16:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants