Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add test to enable sync of federated shared resource #11026

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Feb 18, 2025

Description

This PR adds following test scenarios to enable sync of federated share.

Scenario: enable sync of a federated shared resource
Scenario: enable sync of one of multiple federated shared resources

Enabling sync of a federated share when there's only one share in shared with me doesn't throw any error but enabling sync of a federated share when there are multiple shares in shared with me gives 400 Bad Request error but @client.synchronize is set to true.
See comments: #10719 (comment) and #10719 (comment)

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Feb 18, 2025
@prashant-gurung899 prashant-gurung899 force-pushed the test/enable-sync-ocm-shares branch 4 times, most recently from 2754965 to 8cf9bef Compare February 20, 2025 07:08
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review February 20, 2025 08:58
@prashant-gurung899 prashant-gurung899 force-pushed the test/enable-sync-ocm-shares branch 3 times, most recently from 748700d to 70d1a31 Compare February 21, 2025 07:06
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't bug about hide and enable sync. I can't see hide test step . You did that in another PR

Comment on lines +1256 to +1360
When user "Brian" lists the shares shared with him using the Graph API
Then the HTTP status code should be "200"
And the JSON data of the response should match
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to check share-with-me ?
I am confused bug occur in which step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used that step to check the value of @client.synchronize in the response.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of @client.synchronize in the response of enabling sync request is false. And when sharedWithMe is checked, it's set to true. May be it's a bug in OCM shares.

synchronize.webm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not enable sync step response should be check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but as you can see the value of @client.synchronize in the response of enable sync is false. So, i listed the shareWithMe to check the value. And I am not sure it it's the expected behaviour.

Comment on lines +1256 to +1360
When user "Brian" lists the shares shared with him using the Graph API
Then the HTTP status code should be "200"
And the JSON data of the response should match
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not enable sync step response should be check?

@prashant-gurung899 prashant-gurung899 force-pushed the test/enable-sync-ocm-shares branch from fc32f5b to e1b7fd6 Compare February 27, 2025 06:05
@prashant-gurung899 prashant-gurung899 force-pushed the test/enable-sync-ocm-shares branch 7 times, most recently from 60a5aa2 to 2e6130b Compare March 6, 2025 03:58
@prashant-gurung899 prashant-gurung899 force-pushed the test/enable-sync-ocm-shares branch from 2e6130b to fe01fec Compare March 6, 2025 10:35
Copy link

sonarqubecloud bot commented Mar 6, 2025

@prashant-gurung899 prashant-gurung899 merged commit 9089871 into master Mar 6, 2025
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the test/enable-sync-ocm-shares branch March 6, 2025 11:13
ownclouders pushed a commit that referenced this pull request Mar 6, 2025
[tests-only][full-ci] add test to enable sync of federated shared resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants