-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] add test to enable sync of federated shared resource #11026
Conversation
2754965
to
8cf9bef
Compare
748700d
to
70d1a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't bug about hide and enable sync. I can't see hide test step . You did that in another PR
When user "Brian" lists the shares shared with him using the Graph API | ||
Then the HTTP status code should be "200" | ||
And the JSON data of the response should match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need to check share-with-me ?
I am confused bug occur in which step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used that step to check the value of @client.synchronize
in the response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of @client.synchronize
in the response of enabling sync request is false
. And when sharedWithMe
is checked, it's set to true. May be it's a bug in OCM shares.
synchronize.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not enable sync step response should be check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but as you can see the value of @client.synchronize
in the response of enable sync is false
. So, i listed the shareWithMe
to check the value. And I am not sure it it's the expected behaviour.
70d1a31
to
6386aea
Compare
6386aea
to
1a06a8d
Compare
1a06a8d
to
fc32f5b
Compare
When user "Brian" lists the shares shared with him using the Graph API | ||
Then the HTTP status code should be "200" | ||
And the JSON data of the response should match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not enable sync step response should be check?
fc32f5b
to
e1b7fd6
Compare
60a5aa2
to
2e6130b
Compare
Signed-off-by: prashant-gurung899 <[email protected]>
2e6130b
to
fe01fec
Compare
|
[tests-only][full-ci] add test to enable sync of federated shared resource
Description
This PR adds following test scenarios to enable sync of federated share.
Enabling sync of a federated share when there's only one share in
shared with me
doesn't throw any error but enabling sync of a federated share when there are multiple shares inshared with me
gives400 Bad Request
error but@client.synchronize
is set to true.See comments: #10719 (comment) and #10719 (comment)
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: