[QA] Test coverage for OCM bugs

[prashant-gurung899]

Description

Reference of OCM bugs collection: #9735

OCM setup : https://owncloud.dev/ocis/development/testing/#running-test-suite-with-federated-sharing-ocm
Future Federated space concept #10065

Bug Report

• OCM. [QA] federated user from different instances are indistinguishable when they share the same full name #10734
  • Test:
• [QA][OCM] Hide & Enable Sync fail with received federated shares #10719 @prashant-gurung899
  • Tests:
    • hide [tests-only][full-ci] add test to hide federated shared resource #11024
    • unhide
    • enable sync - [tests-only][full-ci] add test to enable sync of federated shared resource #11026
    • disable sync
• OCM. delete-accepted-user endpoint always returns 200 #10223 @anon-pradip
  • Tests:
    • [tests-only][full-ci] Test coverage for federated user trying to delete deleted federation connection #11017
    • edge cases: OCM. delete-accepted-user endpoint always returns 200 #10223 (comment)
• https://github.com/owncloud/enterprise/issues/7073
  • Test:
• Notifications related issues and tests will be tracked in [QA] tests for OCM notifications #11062)

Tests Added

• OCM. Restrict sharing roles to Editor / Viewer in sharing dialog #9745
  • Test coverage tracked in [QA] tests to list item permissions with filters #10728
• https://github.com/owncloud/enterprise/issues/7075 @PrajwolAmatya
  • Test: [tests-only][full-ci] added test to delete ocm shares #10995
• OCM. federated connection is not dropped when one of the users deletes the connection #10216
  try to find federation users after deleting federated connection
  • Test: already covered in [test-only] delete connection tests #10224
• [OCM] Users can invite themselves to their own federated connection #11004 @PrajwolAmatya
  • Test: [tests-only][full-ci]added test for user trying to accept federation share invitation from same instance #11015
• [OCM] Sharee can access expired federated share #11033
  • test: [tests-only][full-ci]Add test for ocm share expiry #11034
• Changing permissions for federated shares #11022
  • Test: already exists

    ocis/tests/acceptance/features/apiOcm/share.feature

    Line 1069 in c954c90

    Scenario: federated user tries to update a shared file after local user updates role

• [OCM] User can share resource to federated user with permission roles that is not allowed #10824 @PrajwolAmatya
  • Test: [tests-only][full-ci] added test to enable disable Secure Viewer permissions role for federated shares #10823
• [OCM] federated user trying to download file shared with permissions role Secure Viewer returns 500 status code #10822 @PrajwolAmatya
  • Test: [tests-only][full-ci] added test to enable disable Secure Viewer permissions role for federated shares #10823
• OCM. folders are created with “/” in the shares #10582 @prashant-gurung899
  • Test: [tests-only][full-ci] add test to create folder inside federated share #11002
• [OCM] roles id not available on sharedWithMe response when listing shares shared with editor role #11054 @PrajwolAmatya
  • Test: [tests-only][full-ci] added test for federated user to list share shared with Editor role #11056

[wkloucek]

@prashant-gurung899 Sorry for hijacking this issue, but are there by any chance some concurrency tests already? Something like creating two OCM shares at "the same time" (I'm not sure if we need / can achieve exact same time execution). I'd be curios if we could see something like race condition situations with the current single file JSON backend if we send multiple requests at once.

[saw-jan]

We have an open ticket for parallel sharing (but that have different use-cases than just a share).

But if it's just doing multiple shares by a single user in parallel, then maybe it's possible with the current API test setup.

[wkloucek]

Nice thanks for that information! That's what I wanted to know. 👍

[saw-jan]

Nice thanks for that information! That's what I wanted to know. 👍

So testing multiple parallel sharing by a single user will do for com? should we add such test for ocm?

[wkloucek]

So testing multiple parallel sharing by a single user will do for com? should we add such test for ocm?

Yes, if it is an easy win. If it's to much effort, we can skip it for now.

[saw-jan]

Yes, if it is an easy win. If it's to much effort, we can skip it for now.

Thanks, we will let you know

[saw-jan]

Parallel ocm sharing tests will be tracked in #11035

[saw-jan]

Before closing this please check that the added tests are not in the expected failure list
maybe not because at the time when we finish tests for all bug reports, some might not be fixed