Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/owncloud-online-screentshots] Create Screenshots for Branded Builds with Fastlane #912

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Mar 1, 2021

Description

Changed the screenshot UI tests to support creating screenshots from branded builds like ownCloud.online.

Related Issue

Motivation and Context

Automatically generate UI screenshots from a branded build

How Has This Been Tested?

  • change variable let takeBrandedScreenshots to true in ownCloudScreenshotsTests.swift
  • run fastlane with the following command: fastlane release_on_appstore create_release_notes:false create_screenshots:true deliver:false build_regular_app:false build_emm_app:false build_owncloud_online_app:true

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@hosy hosy requested a review from mneuwert March 1, 2021 14:14
@hosy hosy merged commit e8a6345 into milestone/11.5.2 Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/owncloud-online-screentshots branch March 2, 2021 12:43
hosy added a commit that referenced this pull request Mar 3, 2021
* Preparing new version: changed version and build number to 11.5.2 and 188

* Add Themeable support to the Acknowledgements (#900)

* [feature/flat-mdm-settings] Support for MDM setting hierarchies with flat keys (#904)

* - automatic termination + relaunch by notification on MDM changes push
- fix indentation

* - react to setting changes pushed via MDM differently, in a two-step process
	- first notify the user about the changes
	- if the user taps the notification, schedule a relaunch notification and then quit
	- if the user taps the relaunch notification, the app is launched
- request authorization to post notifications if needed

* [fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad (#905)

* Fixing the thumbnail view position on the iPad in portrait view
- added orientation changed notification to recreate the constrains, when the device was rotated

* added changelog issue

* Calens changelog updated

* fixed QA finding (jumpy thumbnail view on iPhone)

* isPortrait mode is not working and removed it with size class

Co-authored-by: hosy <[email protected]>

* [fix/collapsible-progress-bar-position-flex] Collapse Progress Bar in Detail View (#911)

* Accessing hyper links in PDF view (#913)

* Updated release notes for version 11.5.2

* Calens changelog updated

* [feature/owncloud-online-screentshots] Create Screenshots for Branded Builds with Fastlane (#912)

* updated In-App release notes with marketing fix

* moved calens changelog files into release folder

* Calens changelog updated

* updated SDK to latest master commit

Co-authored-by: Felix Schwarz <[email protected]>
Co-authored-by: hosy <[email protected]>
Co-authored-by: Michael Neuwert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants