-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad #905
Conversation
- added orientation changed notification to recreate the constrains, when the device was rotated
(1)
then it should only affect iPad. I have check in iPhone, and i detected a weird behaviour in portrait mode: the position of the thumbnail list changes from bottom to right at the time you move the device (not necessary to change orientation): VID_20210301_095612.mp4 |
@jesmrec finding (1) is fixed and you can have a look again. Thank you! |
unfortunately, i still reproduce (1) with commit |
@jesmrec hopefully with the latest commit it is solved. |
Not it is correctly fixed. Approved on my side. |
* Preparing new version: changed version and build number to 11.5.2 and 188 * Add Themeable support to the Acknowledgements (#900) * [feature/flat-mdm-settings] Support for MDM setting hierarchies with flat keys (#904) * - automatic termination + relaunch by notification on MDM changes push - fix indentation * - react to setting changes pushed via MDM differently, in a two-step process - first notify the user about the changes - if the user taps the notification, schedule a relaunch notification and then quit - if the user taps the relaunch notification, the app is launched - request authorization to post notifications if needed * [fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad (#905) * Fixing the thumbnail view position on the iPad in portrait view - added orientation changed notification to recreate the constrains, when the device was rotated * added changelog issue * Calens changelog updated * fixed QA finding (jumpy thumbnail view on iPhone) * isPortrait mode is not working and removed it with size class Co-authored-by: hosy <[email protected]> * [fix/collapsible-progress-bar-position-flex] Collapse Progress Bar in Detail View (#911) * Accessing hyper links in PDF view (#913) * Updated release notes for version 11.5.2 * Calens changelog updated * [feature/owncloud-online-screentshots] Create Screenshots for Branded Builds with Fastlane (#912) * updated In-App release notes with marketing fix * moved calens changelog files into release folder * Calens changelog updated * updated SDK to latest master commit Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: hosy <[email protected]> Co-authored-by: Michael Neuwert <[email protected]>
Description
This PR changes the position of the PDF thumbnail view on the iPad from the bottom to the right position.
Related Issue
Motivation and Context
There are some reasons why the right position makes more sense:
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
QA