-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: feature/xml systemout #720
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9e2ac95
Merge pull request #1 from ovh/master
ivan-velasco de6f518
Merge branch 'ovh:master' into master
ivan-velasco 9b87da2
Merge branch 'master' of https://github.com/ivan-velasco/venom
ivan-velasco b7bd94f
Merge remote-tracking branch 'origin/master'
ivan-velasco be21683
Merge branch 'ovh:master' into master
ivan-velasco 4d3344f
Merge branch 'ovh:master' into master
ivan-velasco 0166a84
Merge branch 'ovh:master' into master
ivan-velasco e104d43
Merge branch 'ovh:master' into master
ivan-velasco 91d92d5
output: xml format now will print systemout if errors occur. User can…
ivan-velasco 3974c8d
http: Result object expanded to include "systemout" this will include…
ivan-velasco 9bfdbf6
Merge branch 'master' into feature/xml-systemout
ivan-velasco 90e14ff
Merge branch 'master' into feature/xml-systemout
ivan-velasco ebd1b2f
Merge branch 'master' into feature/xml-systemout
yesnault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok with that @ivan-velasco ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to test this change out locally today @yesnault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesnault tested this finally today and it causes the xml report to exclude this information
When the property is set
Systemout string json:"-" yaml:"-"
json report
When the property is set
Systemout string json:"systemout,omitempty" yaml:"systemout,omitempty"
, then xml report shows up properlyjson report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesnault Any thoughts on this? Has been very helpful in identifying errors quickly.