-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: feature/xml systemout #720
Conversation
feat: removed result from testcase variables and removed errors warni…
… enable to print always with verbose set higher than 1 Signed-off-by: Ivan Velasco <[email protected]>
… the Body or BodyJSON response values Signed-off-by: Ivan Velasco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for this proposal. I'm not sure about the performance impact with big payload, but yes, this could be useful. LGTM.
After re-reading, I think that the body will be present twice in the JSON output. Maybe we can avoid that with the json annotation to '-'. |
@@ -68,6 +68,7 @@ type Result struct { | |||
BodyJSON interface{} `json:"bodyjson,omitempty" yaml:"bodyjson,omitempty"` | |||
Headers Headers `json:"headers,omitempty" yaml:"headers,omitempty"` | |||
Err string `json:"err,omitempty" yaml:"err,omitempty"` | |||
Systemout string `json:"systemout,omitempty" yaml:"systemout,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Systemout string `json:"systemout,omitempty" yaml:"systemout,omitempty"` | |
Systemout string `json:"-" yaml:"-"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok with that @ivan-velasco ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to test this change out locally today @yesnault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesnault tested this finally today and it causes the xml report to exclude this information
When the property is set Systemout string json:"-" yaml:"-"
<system-out><![CDATA[
json report
"systemout": "\n",
When the property is set Systemout string json:"systemout,omitempty" yaml:"systemout,omitempty"
, then xml report shows up properly
<system-out><![CDATA[
PATCH-----http://
json report
"result.systemout": "PATCH-----http://
"systemout": "PATCH-----http://
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesnault Any thoughts on this? Has been very helpful in identifying errors quickly.
http: addition of 'systemout' to the XML report for enhanced debugging capabilities, eliminating the need to solely rely on 'INFO' messages or enabling verbose mode after a complete run. With this enhancement, 'systemout' will be included in the XML output specifically when errors occur, improving the troubleshooting and diagnostic process.