-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add natural language datetime assertion #711
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
name: test ShouldHappenAfter - use RFC3339 format | ||
name: test ShouldHappenAfter | ||
vars: | ||
time_with_5s_before: 2006-01-02T15:04:00+07:00 | ||
time: 2006-01-02T15:04:05+07:00 | ||
testcases: | ||
- name: test assertion | ||
- name: test assertion with RFC3339 date format | ||
steps: | ||
- type: exec | ||
script: "echo {{.time}}" | ||
assertions: | ||
- result.systemout ShouldHappenAfter "{{.time_with_5s_before}}" | ||
- result.systemout ShouldHappenAfter "{{.time_with_5s_before}}" | ||
- name: test assertion with humanize format | ||
steps: | ||
- type: exec | ||
script: "echo {{.venom.datetime}}" | ||
assertions: | ||
- "result.systemout ShouldHappenAfter yesterday" | ||
- "result.systemout ShouldHappenAfter '5 minutes ago'" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
name: test ShouldHappenBefore - use RFC3339 format | ||
name: test ShouldHappenBefore | ||
vars: | ||
time: 2006-01-02T15:04:05+07:00 | ||
time_with_5s_after: 2006-01-02T15:04:10+07:00 | ||
testcases: | ||
- name: test assertion | ||
- name: test assertion with RFC3339 date format | ||
steps: | ||
- type: exec | ||
script: "echo {{.time}}" | ||
assertions: | ||
- result.systemout ShouldHappenBefore "{{.time_with_5s_after}}" | ||
- result.systemout ShouldHappenBefore "{{.time_with_5s_after}}" | ||
- name: test assertion with humanize format | ||
steps: | ||
- type: exec | ||
script: "echo {{.venom.datetime}}" | ||
assertions: | ||
- "result.systemout ShouldHappenBefore tomorrow" | ||
- "result.systemout ShouldHappenBefore '5 minutes from now'" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,19 @@ | ||
name: test ShouldHappenBetween - use RFC3339 format | ||
name: test ShouldHappenBetween | ||
vars: | ||
time_with_5s_before: 2006-01-02T15:04:00+07:00 | ||
time: 2006-01-02T15:04:05+07:00 | ||
time_with_5s_after: 2006-01-02T15:04:10+07:00 | ||
testcases: | ||
- name: test assertion | ||
- name: test assertion with RFC3339 date format | ||
steps: | ||
- type: exec | ||
script: "echo {{.time}}" | ||
assertions: | ||
- result.systemout ShouldHappenBetween "{{.time_with_5s_before}}" "{{.time_with_5s_after}}" | ||
- result.systemout ShouldHappenBetween "{{.time_with_5s_before}}" "{{.time_with_5s_after}}" | ||
- name: test assertion with humanize format | ||
steps: | ||
- type: exec | ||
script: "echo {{.venom.datetime}}" | ||
assertions: | ||
- "result.systemout ShouldHappenBetween yesterday tomorrow" | ||
- "result.systemout ShouldHappenBetween '5 minutes ago' '5 minutes from now'" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
name: test ShouldHappenOnOrAfter - use RFC3339 format | ||
name: test ShouldHappenOnOrAfter | ||
vars: | ||
time_with_5s_before: 2006-01-02T15:04:00+07:00 | ||
time: 2006-01-02T15:04:05+07:00 | ||
testcases: | ||
- name: test assertion | ||
- name: test assertion with RFC3339 date format | ||
steps: | ||
- type: exec | ||
script: "echo {{.time}}" | ||
assertions: | ||
- result.systemout ShouldHappenOnOrAfter "{{.time_with_5s_before}}" | ||
- result.systemout ShouldHappenOnOrAfter "{{.time_with_5s_before}}" | ||
- name: test assertion with humanize format | ||
steps: | ||
- type: exec | ||
script: "echo {{.venom.datetime}}" | ||
assertions: | ||
- "result.systemout ShouldHappenOnOrAfter yesterday" | ||
- "result.systemout ShouldHappenOnOrAfter '5 minutes ago'" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
name: test ShouldHappenOnOrBefore - use RFC3339 format | ||
name: test ShouldHappenOnOrBefore | ||
vars: | ||
time: 2006-01-02T15:04:05+07:00 | ||
time_with_5s_after: 2006-01-02T15:04:10+07:00 | ||
testcases: | ||
- name: test assertion | ||
- name: test assertion with RFC3339 date format | ||
steps: | ||
- type: exec | ||
script: "echo {{.time}}" | ||
assertions: | ||
- result.systemout ShouldHappenOnOrBefore "{{.time_with_5s_after}}" | ||
- result.systemout ShouldHappenOnOrBefore "{{.time_with_5s_after}}" | ||
- name: test assertion with humanize format | ||
steps: | ||
- type: exec | ||
script: "echo {{.venom.datetime}}" | ||
assertions: | ||
- "result.systemout ShouldHappenOnOrBefore tomorrow" | ||
- "result.systemout ShouldHappenOnOrBefore '5 minutes from now'" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing:
assertions_test.go:1388: ShouldHappenBetween() error = expected '2023-09-07 09:06:34.28230254 +0000 UTC m=+0.000668682' to be between '2023-09-07 01:00:00 +0000 UTC' and '2023-09-07 01:00:00 +0000 UTC' , wantErr false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhzs it's ok, thank you. LGTM