-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add natural language datetime assertion #711
Conversation
3993b50
to
2ad9c28
Compare
CDS Report build-venom-a#85.0 ✘
|
@@ -1346,6 +1374,13 @@ func TestShouldHappenBetween(t *testing.T) { | |||
}, | |||
wantErr: true, | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing:
assertions_test.go:1388: ShouldHappenBetween() error = expected '2023-09-07 09:06:34.28230254 +0000 UTC m=+0.000668682' to be between '2023-09-07 01:00:00 +0000 UTC' and '2023-09-07 01:00:00 +0000 UTC' , wantErr false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhzs it's ok, thank you. LGTM
Signed-off-by: Rheza Satria <[email protected]>
Signed-off-by: Rheza Satria <[email protected]>
Signed-off-by: Rheza Satria <[email protected]>
095ff23
to
b12b6df
Compare
CDS Report build-venom-a#94.0 ✘
|
CDS Report build-venom-a#94.1 ✘
|
CDS Report build-venom-a#94.2 ✘
|
CDS Report build-venom-a#94.3 ✘
|
This PR will add ability to easily assert date time.
Now we can use time assertion in natural language.
Example:
This PR uses https://github.com/tj/go-naturaldate to support the natural language.