Skip to content

feat: Add support for the ORA Grading MFE - #89

Merged
arbrandes merged 1 commit into
overhangio:palmfrom
arbrandes:add-ora-grading
Jun 5, 2023
Merged

feat: Add support for the ORA Grading MFE#89
arbrandes merged 1 commit into
overhangio:palmfrom
arbrandes:add-ora-grading

Conversation

@arbrandes

@arbrandes arbrandes commented Nov 23, 2022

Copy link
Copy Markdown
Collaborator

The MFE is accessible by instructors in ORA exercises that have explicit staff grading steps.

The corresponding waffle flag is installed and enabled by default.

Depends on:

@arbrandes
arbrandes force-pushed the add-ora-grading branch 3 times, most recently from a9b9466 to d6b8bf6 Compare November 23, 2022 19:15
@arbrandes
arbrandes marked this pull request as ready for review November 23, 2022 21:53
@arbrandes
arbrandes requested a review from regisb November 23, 2022 21:53
Comment thread tutormfe/plugin.py Outdated

@regisb regisb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@arbrandes

Copy link
Copy Markdown
Collaborator Author

For the record, we need this fix to land before we can merge this.

@arbrandes

Copy link
Copy Markdown
Collaborator Author

This has also been rebased, but at a reduced priority since we haven't gotten the blocking upstream PR merged, yet.

@arbrandes
arbrandes force-pushed the add-ora-grading branch 2 times, most recently from 148934a to c85161d Compare May 15, 2023 17:09
@arbrandes
arbrandes changed the base branch from nightly to palm May 15, 2023 17:11
@arbrandes
arbrandes force-pushed the add-ora-grading branch 2 times, most recently from 89b3602 to af01e4f Compare May 15, 2023 18:35
@arbrandes

Copy link
Copy Markdown
Collaborator Author

This is now:

@vunguyen-dmt

Copy link
Copy Markdown
Contributor

Hi @arbrandes, I've tried ORA grading MFE, there was one issue I found, could you check it in this release.
In Local deployment, when viewing individual submissions, I noticed that file download URLs were relative paths, because of that it could not be displayed, the url was https://{MFE_HOST}/openassessment/fileupload/submissions_attachments/... instead of https://{LMS_HOST}/openassessment/fileupload/submissions_attachments/...
I think the problem could be from this file

  const rendererProps = {
    fileName: file.name,
    url: file.downloadUrl,
    onError: stopLoading,
    onSuccess: () => stopLoading(),
  };

I'm not sure this is an optimal way to fix the problem, but it could be

  const rendererProps = {
    fileName: file.name,
    url: file.downloadUrl && file.downloadUrl.startsWith("/") ? `${baseUrl}${file.downloadUrl}` :  file.downloadUrl,
    onError: stopLoading,
    onSuccess: () => stopLoading(),
  };

@vunguyen-dmt

Copy link
Copy Markdown
Contributor

This may not affect files uploaded to S3, only files uploaded to local storage I think.

The MFE is accessible by instructors in ORA exercises that have explicit staff
grading steps.

The corresponding waffle flag is installed and enabled by default.
@arbrandes

Copy link
Copy Markdown
Collaborator Author

@vunguyen-dmt, do you mind opening an issue in https://github.com/openedx/frontend-app-ora-grading describing the problem you observed, including instructions to reproduce? It's not readily apparent - at least to me - that this is a problem with tutor-mfe.

In any case, I don't think that is a blocker to releasing in Palm, so I'm going to go ahead and merge this.

@arbrandes
arbrandes merged commit 4a72af0 into overhangio:palm Jun 5, 2023
@arbrandes
arbrandes deleted the add-ora-grading branch June 5, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants