[Palm] feat: Support runtime configuration - #185
Merged
arbrandes merged 2 commits intoJun 5, 2023
Conversation
added 2 commits
May 31, 2023 12:46
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335
arbrandes
changed the title
5 tasks
Contributor
Author
|
@ghassanmas, @dcoa, and @MaferMazu, as reviewers of #183, care to give this one a thumbs up? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #185 +/- ##
==========================================================
Coverage 100.00% 100.00%
==========================================================
Files 111 110 -1
Lines 1080 1078 -2
Branches 158 158
==========================================================
- Hits 1080 1078 -2
☔ View full report in Codecov by Sentry. |
|
@arbrandes, do we need to remove the src/config/index.js file? |
Contributor
Author
Ah, nice catch! |
Contributor
Author
|
Oh, wait, it's already removed! Edit: yes, we should remove it, as it's not being used anywhere anymore. |
1 task
MaferMazu
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport to
palm.masterof #183.