-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to quince #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to renaming quickstart to launch in tutor.
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
regisb
reviewed
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you review Dockerfile requirements? Nothing to upgrade there?
README.rst
Outdated
@@ -81,7 +81,7 @@ Once a local repository is mounted in the image, you will have to install all ge | |||
Troubleshooting | |||
--------------- | |||
|
|||
This Tutor plugin is maintained by Ghassan Maslamani from `Zaat.dev <https://Zaat.dev>`__. Community support is available from the official `Open edX forum <https://discuss.openedx.org>`__. Do you need help with this plugin? See the `troubleshooting <https://docs.tutor.overhang.io/troubleshooting.html>`__ section from the Tutor documentation. | |||
This Tutor plugin is maintained by Ghassan Maslamani from `Abstrcat-Technology <https://abstract-technology.de>`__. Community support is available from the official `Open edX forum <https://discuss.openedx.org>`__. Do you need help with this plugin? See the `troubleshooting <https://docs.tutor.overhang.io/troubleshooting.html>`__ section from the Tutor documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abstrcat -> Abstract
And congrats on the new role :)
regisb
force-pushed
the
quince
branch
2 times, most recently
from
December 9, 2023 22:09
0d102ad
to
588d162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Quince, work on progess still: