Authn MFE is broken in nightly

[kdmccormick]

Steps to reproduce

• tutor local start
• Go to http://local.overhang.io
• This should redirect you to http://apps.local.overhang.io/authn/login
• Expected: The login page
• Actual: An unexpected error occurred. Please click the button below to refresh the page.
• Refreshing the page leads the same error

Notes

• I've confirmed that tutor local launch does not fix the issue.
• @bmtcril confirms that that deleting all data and re-launching does not fix the issue.
• @bmtcril was able to disable the mfe plugin, use the legacy login page, re-enable the mfe plugin, and then use the Learning MFE. This implies that the issue is not specific to MFEs or to authentication, but is an issue at intersection of the two and/or the an bug in the Authn MFE iteslf.
• tutor dev also fails.

[ghassanmas]

Hey, probably it would be useful to provide the console output, i,e are there specif API calls that are failing? And with nightly it means it suppose to run frontned-app-authn on master branch correct? both edx-platform and the mfe

[kdmccormick]

• Nothing in the LMS console for either local or dev.
• Nothing in the Authn MFE browser console for local.
• Debug view for Authn MFE in dev shows:

TypeError: secondaryProviders is undefined

Call Stack
 renderThirdPartyAuth
  src/login/LoginPage.jsx:213:38
 renderForm
  src/login/LoginPage.jsx:337:20
 render
  src/login/LoginPage.jsx:379:17
 finishClassComponent
  node_modules/react-dom/cjs/react-dom.development.js:17160:31
 updateClassComponent
  node_modules/react-dom/cjs/react-dom.development.js:17110:44
 beginWork
  node_modules/react-dom/cjs/react-dom.development.js:18620:16
 callCallback
  node_modules/react-dom/cjs/react-dom.development.js:188:14
 invokeGuardedCallbackDev
  node_modules/react-dom/cjs/react-dom.development.js:237:16
 invokeGuardedCallback
  node_modules/react-dom/cjs/react-dom.development.js:292:31
 beginWork$1
  node_modules/react-dom/cjs/react-dom.development.js:23203:28

[ghassanmas]

One guess it might be due to frontend-platform, since it handles the init part, could you try running the authn while dumping the frontend-platform version to 4.1.0

[brian-smith-tcril]

did a little testing on devstack to try to narrow down the issue

in a devstack venv

make dev.up.cms+studio

outside of the devstack venv
cloned latest frontend-app-authn, in the frontend-app-authn dir

nvm use
npm install
npm start

localhost:1999 is working as expected

[ghassanmas]

Humm.. then it can be probably version node conflict, I think tutor tries to build using node 16 while the authin is already updated to 18 openedx/frontend-app-authn/pull/781 to test this one can just check insdie tutor-mfe contianer if assest exists in /openedx/dist/authin

[brian-smith-tcril]

tried

rm -rf node_modules/
nvm use 16
npm install
npm start

still seems to be working

[ghassanmas]

Can you try running it using dynamic config enabled I think this one main difference between devstack and tutor. You would need to swt ENV variable to the minimum needed and then serve the other by setting dynamic config api

[ghassanmas]

[update] I don't know if that's help. but I tried to run/build the authn mfe master while using tutor palm (using palm.master instead of master and it worked with no problem. In any case this probably mean the issue irrelevant to frontend-platform version

[ghassanmas]

I was able to reproduce this issue, and to resolved in hacky way where I cloned maste of authn and then mounted the dist to mfe the container. When I noticed is that the mfe image doesn't have nightly suffix, as opposite the openedx image. So I guess it was using the olive image for nightly.

(edx-env) ➜  tutor-nightly tutor config printvalue DOCKER_IMAGE_OPENEDX
docker.io/overhangio/openedx:15.3.4-nightly
(edx-env) ➜  tutor-nightly tutor config printvalue MFE_DOCKER_IMAGE
docker.io/overhangio/openedx-mfe:15.0.5

So may be running tutor images build mfe suppose to resolve?.... it's building now for me, so I can update when it's done

[kdmccormick]

@arbrandes will you be able to take a look? Is there anything we can do to help?

[arbrandes]

I can take a look over the next couple of days, yes!

[brian-smith-tcril]

I've been doing a bit of digging into this, when running tutor dev start I noticed

  Your models in app(s): 'third_party_auth' have changes that are not yet reflected in a migration, and so won't be applied.
  Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.

when breaking into the errors using a browser debugger I found issues with how we were setting thirdPartyAuthContext, it seems that has changed recently https://github.com/openedx/frontend-app-authn/blame/master/src/common-components/data/service.js#L23

I'm still looking into this, I'll make sure to share updates as I discover more.

[brian-smith-tcril]

Update: running tutor images build authn-dev fixed this for me.

Successfully built b058f87eab3d
Successfully tagged overhangio/openedx-authn-dev:15.0.5

compared to the current image on dockerhub (15.0.2 - 5 months ago) https://hub.docker.com/r/overhangio/authn-dev/tags