Repository navigation
feat(worker_threads) support argv and execArgv options - #7962
Merged
Merged
Conversation
otgerrogla
force-pushed
the
worker-threads
branch
from
January 3, 2024 08:19
d1037ad to
9ed1b0f
Compare
Collaborator
|
This looks great. Thank you for this. Let's let the tests run and merge if the worker tests pass |
Collaborator
|
I made the macOS CI runners bigger to hopefully fix the CI issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for arguments to NodeJS
worker_threadsand web Worker constructor options:argv: set the additional arguments that worker threads see atprocess.argv/Bun.argvafterargv[0](executable path) andargv[1](main script path).execArgv: bun does not use it, but added for compatibility. When the option is set, workers threads see the given string array values atprocess.execArgv, otherwise the value of this defaults to the one of the main thread.Also fixes a small bug where worker threads always had
"bun"as 3rd arg (argv[2]). Now whenargvoption is not specified, threads only seeargv[0]andargv[1]inprocess.argv.Closes #4130
How did you verify your code works?
I wrote automated tests
bun-debug test test-file-name.test)