Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/js/web/fetch/fetch.tls.renegotiation-peer-fixture.mjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions test/js/web/fetch/fetch.tls.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,10 @@ describe.concurrent("fetch-tls", () => {
await using peer = Bun.spawn({
cmd: [nodeExe()!, join(import.meta.dir, "fetch.tls.renegotiation-peer-fixture.mjs")],
env: { ...bunEnv, SERVER_CERT: validTls.cert, SERVER_KEY: validTls.key },
// The runner does not kill the processes of a concurrent test that
// times out. The peer exits when this pipe closes, and the client
// ends with the peer.
stdin: "pipe",
stdout: "pipe",
stderr: "inherit",
});
Expand Down Expand Up @@ -610,13 +614,13 @@ describe.concurrent("fetch-tls", () => {
timeout,
);

// Observed: the request gets no answer, and the test times out. Its write
// parks while the renegotiation runs, and uSockets does not retry it when
// the renegotiation ends.
it.todo(
// The request's write parks while the renegotiation runs. uSockets has to
// retry it when the renegotiation ends, or the request gets no answer.
it.skipIf(!nodeExe())(
"a request that reuses a pooled socket mid-renegotiation gets its answer",
async () => {
const { stdout, exitCode } = await pickUpMidRenegotiation("await-second");
const { stdout, stderr, exitCode } = await pickUpMidRenegotiation("await-second");
expect(stderr).toBe("");
expect(stdout).toEqual(["first ok", "held record type 22", "after the pooled pickup pong", "second ok"]);
expect(exitCode).toBe(0);
},
Expand Down
Loading