Repository navigation
node:net: hold queued _writev chunks by reference instead of concat + native copy #35940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
512ef2f
node:net: feed _writev chunks to the socket one at a time instead of …
robobun d9766f8
lint: read chunk.chunk / this.connecting into locals (no-duplicate-co…
robobun 9de12ed
trim code comments flagged by comment-cop
robobun 55e277b
keep the _writev TODO attached to _writev; drop helper doc comment
robobun dafc8a8
gate writeChunksUntilFull on empty native buffer; primordial slice; r…
robobun 258f882
test: reject serverRecv from the client error handler too
robobun 483a18c
match _write's error code in the _writev close-before-ready path
robobun 1d39cb4
keep the Buffer.concat _writev path on Windows
robobun 6f21740
[autofix.ci] apply automated fixes
autofix-ci[bot] aeb327a
shrink Windows concat comment to one line (comment-cop)
robobun 6d54716
drop unreachable win32 errno arm in _writev/onWritevHandleReady ready…
robobun e87d208
Merge branch 'main' into farm/4a2709d6/net-writev-no-concat
robobun a4f8849
Merge remote-tracking branch 'origin/main' into farm/4a2709d6/net-wri…
robobun 544ff28
mirror #33974's loop-hold contract in the parked _writev path
robobun e677715
Merge remote-tracking branch 'origin/main' into farm/4a2709d6/net-wri…
robobun 53c7991
test: use --expose-gc + globalThis.gc() in the RSS fixture so the sam…
robobun 47ecee5
net: share the _writev dispatch body between the direct and deferred …
robobun 5f37fbb
Merge remote-tracking branch 'origin/main' into farm/4a2709d6/net-wri…
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.