deps: update libarchive to v3.8.5 - #26432
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Collaborator
Contributor
WalkthroughUpdates the libarchive dependency commit hash in the CMake build configuration from 9525f90ca4bd14c7b335e2f8c84a4607b0af6bdf to dd897a78c662a2c7a003e7ec158cea7909557bee. No functional changes to build logic. Changes
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
1 of 2 tasks
Jarred-Sumner
pushed a commit
that referenced
this pull request
Jan 25, 2026
## Summary
- Fixed all `update-*.yml` workflows that were creating duplicate PRs
every week
## Problem
The update workflows (libarchive, zstd, cares, etc.) were using `${{
github.run_number }}` in the branch name, e.g.:
```yaml
branch: deps/update-libarchive-${{ github.run_number }}
```
This caused a new unique branch to be created on every workflow run, so
the `peter-evans/create-pull-request` action couldn't detect existing
PRs and would create duplicates.
**Evidence:** There are currently 8+ open duplicate PRs for libarchive
alone:
- #26432 deps: update libarchive to v3.8.5 (deps/update-libarchive-56)
- #26209 deps: update libarchive to v3.8.5 (deps/update-libarchive-55)
- #25955 deps: update libarchive to v3.8.5 (deps/update-libarchive-54)
- etc.
## Solution
Changed all workflows to use static branch names, e.g.:
```yaml
branch: deps/update-libarchive
```
This allows the action to:
1. Detect if an existing branch/PR already exists
2. Update the existing PR with new changes instead of creating a new one
3. Properly use `delete-branch: true` when the PR is merged
## Files Changed
- `.github/workflows/update-cares.yml`
- `.github/workflows/update-hdrhistogram.yml`
- `.github/workflows/update-highway.yml`
- `.github/workflows/update-libarchive.yml`
- `.github/workflows/update-libdeflate.yml`
- `.github/workflows/update-lolhtml.yml`
- `.github/workflows/update-lshpack.yml`
- `.github/workflows/update-root-certs.yml`
- `.github/workflows/update-sqlite3.yml`
- `.github/workflows/update-vendor.yml`
- `.github/workflows/update-zstd.yml`
## Test plan
- [x] Verified the change is syntactically correct
- [ ] Wait for next scheduled run of any workflow to verify it updates
existing PR instead of creating a new one
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
7 tasks done
Jarred-Sumner
added a commit
that referenced
this pull request
Apr 14, 2026
## What does this PR do? The scheduled `update-*.yml` workflows have been failing since #28640 removed `cmake/targets/*.cmake` — they were still reading pinned commits from those files. The dependency definitions now live in `scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`. **Workflows fixed** — `update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml` now read/write the `_COMMIT` constant in the corresponding `scripts/build/deps/*.ts` file. The replacement step also moved to the safe `env:` pattern instead of inlining `${{ }}` into the shell. **libarchive bumped** — 3.8.1 → 3.8.7 ([compare](libarchive/libarchive@9525f90...ded8229)). `archive_write_add_filter_gzip.c.patch` rebased onto the new upstream, which reformatted the surrounding code; no semantic change — still adds the `gzip:os` option used by `bun pm pack` for reproducible tarballs. The other 7 deps were not version-bumped here; their now-working workflows will open bump PRs on the next scheduled run. Closes [#26652](#26652) Closes [#26432](#26432) Closes [#26209](#26209) Closes [#25955](#25955) Closes [#25818](#25818) Closes [#25726](#25726) Closes [#25625](#25625) Closes [#25507](#25507) Closes [#25380](#25380) ## How did you verify your code works? - [x] `bun scripts/build.ts --target=libarchive` — patches apply cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007` - [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass - [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass - [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased patch is functional - [x] All 8 workflows: extraction sed returns valid 40-char hash from the live `.ts` file (GNU sed) - [x] All 8 workflows: replacement sed rewrites exactly one line, round-trips back through extraction - [x] All 8 workflows: YAML parses, no `cmake` references remain
structwafel
pushed a commit
to structwafel/bun
that referenced
this pull request
Apr 25, 2026
…h#29289) ## What does this PR do? The scheduled `update-*.yml` workflows have been failing since oven-sh#28640 removed `cmake/targets/*.cmake` — they were still reading pinned commits from those files. The dependency definitions now live in `scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`. **Workflows fixed** — `update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml` now read/write the `_COMMIT` constant in the corresponding `scripts/build/deps/*.ts` file. The replacement step also moved to the safe `env:` pattern instead of inlining `${{ }}` into the shell. **libarchive bumped** — 3.8.1 → 3.8.7 ([compare](libarchive/libarchive@9525f90...ded8229)). `archive_write_add_filter_gzip.c.patch` rebased onto the new upstream, which reformatted the surrounding code; no semantic change — still adds the `gzip:os` option used by `bun pm pack` for reproducible tarballs. The other 7 deps were not version-bumped here; their now-working workflows will open bump PRs on the next scheduled run. Closes [oven-sh#26652](oven-sh#26652) Closes [oven-sh#26432](oven-sh#26432) Closes [oven-sh#26209](oven-sh#26209) Closes [oven-sh#25955](oven-sh#25955) Closes [oven-sh#25818](oven-sh#25818) Closes [oven-sh#25726](oven-sh#25726) Closes [oven-sh#25625](oven-sh#25625) Closes [oven-sh#25507](oven-sh#25507) Closes [oven-sh#25380](oven-sh#25380) ## How did you verify your code works? - [x] `bun scripts/build.ts --target=libarchive` — patches apply cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007` - [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass - [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass - [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased patch is functional - [x] All 8 workflows: extraction sed returns valid 40-char hash from the live `.ts` file (GNU sed) - [x] All 8 workflows: replacement sed rewrites exactly one line, round-trips back through extraction - [x] All 8 workflows: YAML parses, no `cmake` references remain
xhjkl
pushed a commit
to xhjkl/bun
that referenced
this pull request
May 14, 2026
## Summary
- Fixed all `update-*.yml` workflows that were creating duplicate PRs
every week
## Problem
The update workflows (libarchive, zstd, cares, etc.) were using `${{
github.run_number }}` in the branch name, e.g.:
```yaml
branch: deps/update-libarchive-${{ github.run_number }}
```
This caused a new unique branch to be created on every workflow run, so
the `peter-evans/create-pull-request` action couldn't detect existing
PRs and would create duplicates.
**Evidence:** There are currently 8+ open duplicate PRs for libarchive
alone:
- oven-sh#26432 deps: update libarchive to v3.8.5 (deps/update-libarchive-56)
- oven-sh#26209 deps: update libarchive to v3.8.5 (deps/update-libarchive-55)
- oven-sh#25955 deps: update libarchive to v3.8.5 (deps/update-libarchive-54)
- etc.
## Solution
Changed all workflows to use static branch names, e.g.:
```yaml
branch: deps/update-libarchive
```
This allows the action to:
1. Detect if an existing branch/PR already exists
2. Update the existing PR with new changes instead of creating a new one
3. Properly use `delete-branch: true` when the PR is merged
## Files Changed
- `.github/workflows/update-cares.yml`
- `.github/workflows/update-hdrhistogram.yml`
- `.github/workflows/update-highway.yml`
- `.github/workflows/update-libarchive.yml`
- `.github/workflows/update-libdeflate.yml`
- `.github/workflows/update-lolhtml.yml`
- `.github/workflows/update-lshpack.yml`
- `.github/workflows/update-root-certs.yml`
- `.github/workflows/update-sqlite3.yml`
- `.github/workflows/update-vendor.yml`
- `.github/workflows/update-zstd.yml`
## Test plan
- [x] Verified the change is syntactically correct
- [ ] Wait for next scheduled run of any workflow to verify it updates
existing PR instead of creating a new one
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
xhjkl
pushed a commit
to xhjkl/bun
that referenced
this pull request
May 14, 2026
…h#29289) ## What does this PR do? The scheduled `update-*.yml` workflows have been failing since oven-sh#28640 removed `cmake/targets/*.cmake` — they were still reading pinned commits from those files. The dependency definitions now live in `scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`. **Workflows fixed** — `update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml` now read/write the `_COMMIT` constant in the corresponding `scripts/build/deps/*.ts` file. The replacement step also moved to the safe `env:` pattern instead of inlining `${{ }}` into the shell. **libarchive bumped** — 3.8.1 → 3.8.7 ([compare](libarchive/libarchive@9525f90...ded8229)). `archive_write_add_filter_gzip.c.patch` rebased onto the new upstream, which reformatted the surrounding code; no semantic change — still adds the `gzip:os` option used by `bun pm pack` for reproducible tarballs. The other 7 deps were not version-bumped here; their now-working workflows will open bump PRs on the next scheduled run. Closes [oven-sh#26652](oven-sh#26652) Closes [oven-sh#26432](oven-sh#26432) Closes [oven-sh#26209](oven-sh#26209) Closes [oven-sh#25955](oven-sh#25955) Closes [oven-sh#25818](oven-sh#25818) Closes [oven-sh#25726](oven-sh#25726) Closes [oven-sh#25625](oven-sh#25625) Closes [oven-sh#25507](oven-sh#25507) Closes [oven-sh#25380](oven-sh#25380) ## How did you verify your code works? - [x] `bun scripts/build.ts --target=libarchive` — patches apply cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007` - [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass - [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass - [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased patch is functional - [x] All 8 workflows: extraction sed returns valid 40-char hash from the live `.ts` file (GNU sed) - [x] All 8 workflows: replacement sed rewrites exactly one line, round-trips back through extraction - [x] All 8 workflows: YAML parses, no `cmake` references remain
liooil
pushed a commit
to liooil/poly
that referenced
this pull request
Aug 7, 2026
## What does this PR do?
The scheduled `update-*.yml` workflows have been failing since #28640
removed `cmake/targets/*.cmake` — they were still reading pinned commits
from those files. The dependency definitions now live in
`scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`.
**Workflows fixed** —
`update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml`
now read/write the `_COMMIT` constant in the corresponding
`scripts/build/deps/*.ts` file. The replacement step also moved to the
safe `env:` pattern instead of inlining `${{ }}` into the shell.
**libarchive bumped** — 3.8.1 → 3.8.7
([compare](libarchive/libarchive@9525f90...ded8229)).
`archive_write_add_filter_gzip.c.patch` rebased onto the new upstream,
which reformatted the surrounding code; no semantic change — still adds
the `gzip:os` option used by `bun pm pack` for reproducible tarballs.
The other 7 deps were not version-bumped here; their now-working
workflows will open bump PRs on the next scheduled run.
Closes [oven-sh/bun#26652](oven-sh/bun#26652)
Closes [oven-sh/bun#26432](oven-sh/bun#26432)
Closes [oven-sh/bun#26209](oven-sh/bun#26209)
Closes [oven-sh/bun#25955](oven-sh/bun#25955)
Closes [oven-sh/bun#25818](oven-sh/bun#25818)
Closes [oven-sh/bun#25726](oven-sh/bun#25726)
Closes [oven-sh/bun#25625](oven-sh/bun#25625)
Closes [oven-sh/bun#25507](oven-sh/bun#25507)
Closes [oven-sh/bun#25380](oven-sh/bun#25380)
## How did you verify your code works?
- [x] `bun scripts/build.ts --target=libarchive` — patches apply
cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007`
- [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass
- [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass
- [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased
patch is functional
- [x] All 8 workflows: extraction sed returns valid 40-char hash from
the live `.ts` file (GNU sed)
- [x] All 8 workflows: replacement sed rewrites exactly one line,
round-trips back through extraction
- [x] All 8 workflows: YAML parses, no `cmake` references remain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates libarchive to version v3.8.5
Compare: libarchive/libarchive@9525f90...dd897a7
Auto-updated by this workflow