deps: update libarchive to v3.8.4 - #25380
github-actions[bot] wants to merge 1 commit into
Conversation
WalkthroughUpdated the libarchive repository commit hash in the CMake build configuration from Changes
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Comment |
## What does this PR do? The scheduled `update-*.yml` workflows have been failing since #28640 removed `cmake/targets/*.cmake` — they were still reading pinned commits from those files. The dependency definitions now live in `scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`. **Workflows fixed** — `update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml` now read/write the `_COMMIT` constant in the corresponding `scripts/build/deps/*.ts` file. The replacement step also moved to the safe `env:` pattern instead of inlining `${{ }}` into the shell. **libarchive bumped** — 3.8.1 → 3.8.7 ([compare](libarchive/libarchive@9525f90...ded8229)). `archive_write_add_filter_gzip.c.patch` rebased onto the new upstream, which reformatted the surrounding code; no semantic change — still adds the `gzip:os` option used by `bun pm pack` for reproducible tarballs. The other 7 deps were not version-bumped here; their now-working workflows will open bump PRs on the next scheduled run. Closes [#26652](#26652) Closes [#26432](#26432) Closes [#26209](#26209) Closes [#25955](#25955) Closes [#25818](#25818) Closes [#25726](#25726) Closes [#25625](#25625) Closes [#25507](#25507) Closes [#25380](#25380) ## How did you verify your code works? - [x] `bun scripts/build.ts --target=libarchive` — patches apply cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007` - [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass - [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass - [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased patch is functional - [x] All 8 workflows: extraction sed returns valid 40-char hash from the live `.ts` file (GNU sed) - [x] All 8 workflows: replacement sed rewrites exactly one line, round-trips back through extraction - [x] All 8 workflows: YAML parses, no `cmake` references remain
…h#29289) ## What does this PR do? The scheduled `update-*.yml` workflows have been failing since oven-sh#28640 removed `cmake/targets/*.cmake` — they were still reading pinned commits from those files. The dependency definitions now live in `scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`. **Workflows fixed** — `update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml` now read/write the `_COMMIT` constant in the corresponding `scripts/build/deps/*.ts` file. The replacement step also moved to the safe `env:` pattern instead of inlining `${{ }}` into the shell. **libarchive bumped** — 3.8.1 → 3.8.7 ([compare](libarchive/libarchive@9525f90...ded8229)). `archive_write_add_filter_gzip.c.patch` rebased onto the new upstream, which reformatted the surrounding code; no semantic change — still adds the `gzip:os` option used by `bun pm pack` for reproducible tarballs. The other 7 deps were not version-bumped here; their now-working workflows will open bump PRs on the next scheduled run. Closes [oven-sh#26652](oven-sh#26652) Closes [oven-sh#26432](oven-sh#26432) Closes [oven-sh#26209](oven-sh#26209) Closes [oven-sh#25955](oven-sh#25955) Closes [oven-sh#25818](oven-sh#25818) Closes [oven-sh#25726](oven-sh#25726) Closes [oven-sh#25625](oven-sh#25625) Closes [oven-sh#25507](oven-sh#25507) Closes [oven-sh#25380](oven-sh#25380) ## How did you verify your code works? - [x] `bun scripts/build.ts --target=libarchive` — patches apply cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007` - [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass - [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass - [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased patch is functional - [x] All 8 workflows: extraction sed returns valid 40-char hash from the live `.ts` file (GNU sed) - [x] All 8 workflows: replacement sed rewrites exactly one line, round-trips back through extraction - [x] All 8 workflows: YAML parses, no `cmake` references remain
…h#29289) ## What does this PR do? The scheduled `update-*.yml` workflows have been failing since oven-sh#28640 removed `cmake/targets/*.cmake` — they were still reading pinned commits from those files. The dependency definitions now live in `scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`. **Workflows fixed** — `update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml` now read/write the `_COMMIT` constant in the corresponding `scripts/build/deps/*.ts` file. The replacement step also moved to the safe `env:` pattern instead of inlining `${{ }}` into the shell. **libarchive bumped** — 3.8.1 → 3.8.7 ([compare](libarchive/libarchive@9525f90...ded8229)). `archive_write_add_filter_gzip.c.patch` rebased onto the new upstream, which reformatted the surrounding code; no semantic change — still adds the `gzip:os` option used by `bun pm pack` for reproducible tarballs. The other 7 deps were not version-bumped here; their now-working workflows will open bump PRs on the next scheduled run. Closes [oven-sh#26652](oven-sh#26652) Closes [oven-sh#26432](oven-sh#26432) Closes [oven-sh#26209](oven-sh#26209) Closes [oven-sh#25955](oven-sh#25955) Closes [oven-sh#25818](oven-sh#25818) Closes [oven-sh#25726](oven-sh#25726) Closes [oven-sh#25625](oven-sh#25625) Closes [oven-sh#25507](oven-sh#25507) Closes [oven-sh#25380](oven-sh#25380) ## How did you verify your code works? - [x] `bun scripts/build.ts --target=libarchive` — patches apply cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007` - [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass - [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass - [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased patch is functional - [x] All 8 workflows: extraction sed returns valid 40-char hash from the live `.ts` file (GNU sed) - [x] All 8 workflows: replacement sed rewrites exactly one line, round-trips back through extraction - [x] All 8 workflows: YAML parses, no `cmake` references remain
## What does this PR do?
The scheduled `update-*.yml` workflows have been failing since #28640
removed `cmake/targets/*.cmake` — they were still reading pinned commits
from those files. The dependency definitions now live in
`scripts/build/deps/*.ts` as `const <NAME>_COMMIT = "..."`.
**Workflows fixed** —
`update-{libarchive,cares,hdrhistogram,highway,libdeflate,lolhtml,lshpack,zstd}.yml`
now read/write the `_COMMIT` constant in the corresponding
`scripts/build/deps/*.ts` file. The replacement step also moved to the
safe `env:` pattern instead of inlining `${{ }}` into the shell.
**libarchive bumped** — 3.8.1 → 3.8.7
([compare](libarchive/libarchive@9525f90...ded8229)).
`archive_write_add_filter_gzip.c.patch` rebased onto the new upstream,
which reformatted the surrounding code; no semantic change — still adds
the `gzip:os` option used by `bun pm pack` for reproducible tarballs.
The other 7 deps were not version-bumped here; their now-working
workflows will open bump PRs on the next scheduled run.
Closes [oven-sh/bun#26652](oven-sh/bun#26652)
Closes [oven-sh/bun#26432](oven-sh/bun#26432)
Closes [oven-sh/bun#26209](oven-sh/bun#26209)
Closes [oven-sh/bun#25955](oven-sh/bun#25955)
Closes [oven-sh/bun#25818](oven-sh/bun#25818)
Closes [oven-sh/bun#25726](oven-sh/bun#25726)
Closes [oven-sh/bun#25625](oven-sh/bun#25625)
Closes [oven-sh/bun#25507](oven-sh/bun#25507)
Closes [oven-sh/bun#25380](oven-sh/bun#25380)
## How did you verify your code works?
- [x] `bun scripts/build.ts --target=libarchive` — patches apply
cleanly, builds `libarchive.a` with `ARCHIVE_VERSION_NUMBER 3008007`
- [x] `bun bd test test/js/bun/archive.test.ts` — 99 pass
- [x] `bun bd test test/cli/install/bun-pack.test.ts` — 70 pass
- [x] `bun pm pack` gzip header byte 9 = `0xff`, confirming the rebased
patch is functional
- [x] All 8 workflows: extraction sed returns valid 40-char hash from
the live `.ts` file (GNU sed)
- [x] All 8 workflows: replacement sed rewrites exactly one line,
round-trips back through extraction
- [x] All 8 workflows: YAML parses, no `cmake` references remain
What does this PR do?
Updates libarchive to version v3.8.4
Compare: libarchive/libarchive@9525f90...d114cee
Auto-updated by this workflow