Skip to content

fix(Request) change owner ship of the stream to allow cyclic references#23327

Merged
Jarred-Sumner merged 12 commits into
ciro/fix-readable-stream-cycle-ref-step-3from
ciro/fix-readable-stream-cycle-ref-step-4
Oct 7, 2025
Merged

fix(Request) change owner ship of the stream to allow cyclic references#23327
Jarred-Sumner merged 12 commits into
ciro/fix-readable-stream-cycle-ref-step-3from
ciro/fix-readable-stream-cycle-ref-step-4

Conversation

@cirospaciari

Copy link
Copy Markdown
Member

What does this PR do?

This is the 4th step to fix cyclic reference issues with the stream please review #23326 first

How did you verify your code works?

Test + CI

@robobun

robobun commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator
Updated 5:50 AM PT - Oct 7th, 2025

@cirospaciari, your commit 7939812 has 2 failures in Build #28352 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 23327

That installs a local version of the PR into your bun-23327 executable, so you can run:

bun-23327 --bun

@cirospaciari cirospaciari changed the base branch from main to ciro/fix-readable-stream-cycle-ref-step-3 October 7, 2025 06:30
@cirospaciari cirospaciari marked this pull request as ready for review October 7, 2025 06:30
@cirospaciari cirospaciari marked this pull request as draft October 7, 2025 06:31
@cirospaciari cirospaciari force-pushed the ciro/fix-readable-stream-cycle-ref-step-3 branch from df3dcd7 to f358615 Compare October 7, 2025 07:08
@cirospaciari cirospaciari marked this pull request as ready for review October 7, 2025 08:14
@Jarred-Sumner Jarred-Sumner merged commit 76c2325 into ciro/fix-readable-stream-cycle-ref-step-3 Oct 7, 2025
44 of 57 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-readable-stream-cycle-ref-step-4 branch October 7, 2025 09:10
Jarred-Sumner pushed a commit that referenced this pull request Oct 7, 2025
### What does this PR do?
Just a refactoring isolating the usage of Request body this is the first
step necessary for #23327 please
review #23319 first
### How did you verify your code works?
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants