Skip to content

fix(Request) isolate body usage #23326

Merged
Jarred-Sumner merged 5 commits into
ciro/fix-readable-stream-cycle-ref-step-2from
ciro/fix-readable-stream-cycle-ref-step-3
Oct 7, 2025
Merged

fix(Request) isolate body usage #23326
Jarred-Sumner merged 5 commits into
ciro/fix-readable-stream-cycle-ref-step-2from
ciro/fix-readable-stream-cycle-ref-step-3

Conversation

@cirospaciari

@cirospaciari cirospaciari commented Oct 7, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Just a refactoring isolating the usage of Request body this is the first step necessary for #23327 please review #23319 first

How did you verify your code works?

CI

@robobun

robobun commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator
Updated 2:10 AM PT - Oct 7th, 2025

@cirospaciari, your commit 754c316 has 1 failures in Build #28332 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 23326

That installs a local version of the PR into your bun-23326 executable, so you can run:

bun-23326 --bun

@cirospaciari cirospaciari force-pushed the ciro/fix-readable-stream-cycle-ref-step-3 branch from 24028ca to e91479e Compare October 7, 2025 06:11
@cirospaciari cirospaciari changed the title WIP fix(Request) isolate body usage fix(Request) isolate body usage Oct 7, 2025
@cirospaciari cirospaciari marked this pull request as ready for review October 7, 2025 06:31
@cirospaciari cirospaciari force-pushed the ciro/fix-readable-stream-cycle-ref-step-3 branch from df3dcd7 to f358615 Compare October 7, 2025 07:08
…es (#23327)

### What does this PR do?
This is the 4th step to fix cyclic reference issues with the stream
please review #23326 first
### How did you verify your code works?
Test + CI
@Jarred-Sumner Jarred-Sumner merged commit bd96458 into ciro/fix-readable-stream-cycle-ref-step-2 Oct 7, 2025
4 of 6 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-readable-stream-cycle-ref-step-3 branch October 7, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants