Repository navigation
Introduce Bun.fetch.stats - #19750
Open
Jarred-Sumner wants to merge 1 commit into
Open
Jarred-Sumner wants to merge 1 commit into
Jarred-Sumner wants to merge 1 commit into
Conversation
Jarred-Sumner
requested review from
a team and
nektro
and removed request for
a team
May 19, 2025 08:22
Collaborator
|
Updated 2:04 AM PT - May 19th, 2025
✅ @Jarred-Sumner, your commit f42401a4f22192e1af025fa61bc6a9a93697871f passed in 🧪 To try this PR locally: bunx bun-pr 19750That installs a local version of the PR into your bun-19750 --bun |
nektro
reviewed
May 19, 2025
|
|
||
| if (total_requests_succeeded > 0) { | ||
| if (needs_space) try writer.writeAll(Output.prettyFmt(" <d>|<r> ", enable_ansi_colors)); | ||
| needs_space = true; |
Contributor
There was a problem hiding this comment.
was this meant to be false?
Contributor
|
noting that while pr description references the former but the latter is exposed and tested |
Contributor
|
small comments, but was the addition driven by an issue or use case you ran into? curious if you have more info on what led you to this api |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This provides useful statistics about all fetch() requests.
Bun.fetch.stats.requestsBun.fetch.stats.bytesWrittenBun.fetch.stats.bytesReadBun.fetch.stats.failBun.fetch.stats.redirectBun.fetch.stats.successBun.fetch.stats.timeoutBun.fetch.stats.refusedBun.fetch.stats.activeHow did you verify your code works?