[Jarred-Sumner]

What does this PR do?

• Add some locks to logger.Log which is supposed to be threadlocal but ExtractTarball is using the package manager's logger from inside the threadpool, which is not threadsafe.
• Add BUN_DISABLE_ATOMIC_RENAME be able to rule out renameat2 as the cause
• Add BUN_FEATURE_FLAG_DISABLE_INSTALL_INDEX to be able to rule out manifest cache installs as the cause
• Fix saveAsync always being called when manifest cache is diasbled

How did you verify your code works?

[robobun]

^{Updated 1:41 AM PT - May 19th, 2025}

❌ @Jarred-Sumner, your commit 87a3132 has 1 failures in Build #16780:

• test/js/bun/spawn/spawn.test.ts - timeout on 🐧 3.21 x64

---

🧪   To try this PR locally:

bunx bun-pr 19721

That installs a local version of the PR into your bun-19721 executable, so you can run:

bun-19721 --bun

[graphite-app]

There's a potential issue in the lock handling during deinit(). The code panics if tryLock() fails, but the defer block unconditionally calls unlock() regardless of whether the lock was successfully acquired. This could lead to undefined behavior if the panic is caught or in future refactoring.

Consider modifying the code to only unlock if the lock was successfully acquired:

if (Environment.isDebug or Environment.enable_asan) {
    const lock_acquired = log.lock.tryLock();
    if (!lock_acquired) {
        @panic("Cannot deinit the log while a thread is active");
    }
    defer if (lock_acquired) log.lock.unlock();
}

This ensures the lock is only released if it was successfully acquired.

Suggested change

	if (Environment.isDebug or Environment.enable_asan) {
	if (!log.lock.tryLock()) {
	@panic("Cannot deinit the log while a thread is active");
	}
	}
	defer {
	if (Environment.isDebug or Environment.enable_asan) {
	log.lock.unlock();
	}
	}
	if (Environment.isDebug or Environment.enable_asan) {
	const lock_acquired = log.lock.tryLock();
	if (!lock_acquired) {
	@panic("Cannot deinit the log while a thread is active");
	}
	defer if (lock_acquired) log.lock.unlock();
	}

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

[Jarred-Sumner]

I split this PR into 5 separate PRs, but none of them actually fix the issue impacting Codex. My current hunch there is a bug in our HTTP client, but I'm ont sure yet. Please follow along in #19755.

• Add fallback for ADDRCONFIG like Chrome's, avoid glibc UDP port 0 hangs #19753
• [bun install] Don't save manifest cache when --no-cache is passed #19752
• [bun install] Fix race condition when error occurs while extracting tarballs #19751
• Introduce Bun.fetch.stats #19750
• [bun install] Do not prefetch dns for npm registry if proxy  #19749