Skip to content

fix(terminal): clear sessionId on PTY close/exit (#80) #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
outsourc-e merged 1 commit into from
Apr 25, 2026
Merged

fix(terminal): clear sessionId on PTY close/exit (#80) #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/components/terminal/terminal-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,24 @@ export function TerminalPanel({ isMobile }: TerminalPanelProps) {
)
continue
}
if (currentEvent === 'exit' || currentEvent === 'close') {
// Server reported the PTY is gone. Clear the tab's sessionId so
// any subsequent /api/terminal-input or /api/terminal-resize
// calls don't fire against a dead session and 404. (#80)
const exitInfo =
currentEvent === 'exit' && typeof payload === 'object'
? ` (exit code ${payload?.code ?? '?'}${payload?.signal ? `, signal ${payload.signal}` : ''})`
: ''
terminal.writeln(`\r\n\x1b[2m[session ended${exitInfo}]\x1b[0m`)
terminal.writeln(`\x1b[2m[click + to open a new tab, or reload to retry]\x1b[0m`)
setTabs((prev) =>
prev.map((tab) =>
tab.id === tabId ? { ...tab, sessionId: undefined } : tab,
),
)
sessionId = undefined
continue
}
if (currentEvent === 'data') {
const textChunk =
payload?.data ??
Expand Down
Loading