fix(terminal): clear sessionId on PTY close/exit (#80) - #155
Merged
Conversation
… 404ing (#80) When a backend PTY exits (user typed exit, command crashed, server recycled), the SSE stream emits 'event: exit' followed by 'event: close'. The frontend was ignoring both events, so the tab kept its now-dead sessionId. Subsequent /api/terminal-input and /api/terminal-resize calls then 404'd in a tight loop and the user saw a hung terminal until they reloaded. Fix: handle 'exit' and 'close' events in the SSE consumer: - Print a dim '[session ended (exit code N)]' line into xterm so the user knows what happened. - Clear the tab's sessionId in zustand state. handleSendInput and the resize effect both already short-circuit when sessionId is undefined, so the 404 spam stops immediately. - Print a hint that '+' opens a new tab. Auto-reconnect is intentionally not implemented here \u2014 the upstream issue was just the spurious 404s and frozen UI. If we want a 'restart session' button later, we wire it on the same handler.
outsourc-e
added a commit
that referenced
this pull request
May 1, 2026
… 404ing (#80) (#155) When a backend PTY exits (user typed exit, command crashed, server recycled), the SSE stream emits 'event: exit' followed by 'event: close'. The frontend was ignoring both events, so the tab kept its now-dead sessionId. Subsequent /api/terminal-input and /api/terminal-resize calls then 404'd in a tight loop and the user saw a hung terminal until they reloaded. Fix: handle 'exit' and 'close' events in the SSE consumer: - Print a dim '[session ended (exit code N)]' line into xterm so the user knows what happened. - Clear the tab's sessionId in zustand state. handleSendInput and the resize effect both already short-circuit when sessionId is undefined, so the 404 spam stops immediately. - Print a hint that '+' opens a new tab. Auto-reconnect is intentionally not implemented here \u2014 the upstream issue was just the spurious 404s and frozen UI. If we want a 'restart session' button later, we wire it on the same handler. Co-authored-by: Eric <eric@outsourc-e.com> (cherry picked from commit d274636)
JohnGuidry
pushed a commit
to JohnGuidry/hermes-workspace
that referenced
this pull request
May 26, 2026
… 404ing (outsourc-e#80) (outsourc-e#155) When a backend PTY exits (user typed exit, command crashed, server recycled), the SSE stream emits 'event: exit' followed by 'event: close'. The frontend was ignoring both events, so the tab kept its now-dead sessionId. Subsequent /api/terminal-input and /api/terminal-resize calls then 404'd in a tight loop and the user saw a hung terminal until they reloaded. Fix: handle 'exit' and 'close' events in the SSE consumer: - Print a dim '[session ended (exit code N)]' line into xterm so the user knows what happened. - Clear the tab's sessionId in zustand state. handleSendInput and the resize effect both already short-circuit when sessionId is undefined, so the 404 spam stops immediately. - Print a hint that '+' opens a new tab. Auto-reconnect is intentionally not implemented here \u2014 the upstream issue was just the spurious 404s and frozen UI. If we want a 'restart session' button later, we wire it on the same handler. Co-authored-by: Eric <eric@outsourc-e.com> (cherry picked from commit d274636)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80.
When a backend PTY exits, the SSE stream emits exit then close. Frontend was ignoring both, so the tab kept its dead sessionId. Subsequent terminal-input and terminal-resize calls 404 in a tight loop until reload.
Fix: handle exit and close in the SSE consumer; print a dim '[session ended]' line and clear the tab's sessionId. The existing handleSendInput and resize effect already short-circuit on undefined sessionId, so the spam stops immediately.
Reporter @joaompfp's diagnosis was correct; this is exactly the patch they described.
Auto-reconnect intentionally NOT implemented; if we want a restart button later we wire it on the same handler.
TypeScript clean.