Fix size unit inconsistency #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospb19
commented
Sep 5, 2023
| } | ||
|
|
||
| let delimiter = 1000_f64; | ||
| let exponent = cmp::min((num.ln() / 6.90775).floor() as i32, 4); |
There was a problem hiding this comment.
The constant 6.90775 here is arcane-event-horizon-magic, but it works.
If someone wants to refactor and it ends up as fast as it is, that's great, but I'm not the one who's gonna touch this relic.
I actually wanted MB instead of MiB, but I don't know how to the change the code to do so xD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469.
The problem was introduced by the crate
ubyte, which was added in #333, reason is explained at #469.This PR reintroduces @vrmiguel's code at 368a776, but fixed for
GiBinstead ofGB.The code is a bit arcane with one magical constant and sizes are an approximation, but a good enough one for all real user purposes I can think of.
The
humansizecrate is too slow for us, even with theno_allocfeature enabled, so I came full-circle to our original implementation instead.