Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Sergio Benitez's
ubyte
crate instead ofhumansize
.The main reasoning for this is removing the use of
humansize
's inefficientformat_size
function. It could be replaced bySizeFormatter::new(bytes, DECIMAL);
but that seems too verbose.ubyte
's usage instead looks likesize.bytes()
and does not allocateAs another very minor win we get to stop compiling Rust's libm
P.S. I'm not sure why we stopped using our own
Bytes
struct