Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit "./" at the start of the path #109

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Omit "./" at the start of the path #109

merged 2 commits into from
Oct 19, 2021

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 19, 2021

Addresses 3rd of #67

Maybe remove the periods, they are pointless here, syntax feels weird after single quotes: './file'. .

Before

[INFO] "./README.md" extracted. (3.09 kB)
Do you want to overwrite './tests/foo.md'? [Y/n] Y
[INFO] "./tests/foo.md" extracted. (8.06 kB)

After

[INFO] "README.md" extracted. (3.09 kB)
Do you want to overwrite 'tests/foo.md'? [Y/n] Y
[INFO] "tests/foo.md" extracted. (8.06 kB)

@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 19, 2021
@marcospb19
Copy link
Member

Thanks for opening your first PR to ouch! We really appreciate any kind of help 🙂.

I didn't knew this function existed!

(If you don't mind, I made a small change just renaming the imports.)

Merging!

@marcospb19 marcospb19 merged commit 2e6cd89 into ouch-org:master Oct 19, 2021
@marcospb19
Copy link
Member

Are you interested in solving the rest of #67?

@exoego exoego deleted the 67 branch October 19, 2021 21:44
@exoego
Copy link
Contributor Author

exoego commented Oct 19, 2021

@marcospb19
Yes, I will send PRs to address other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants