Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve [INFO] message when decompressing archives #67

Closed
4 tasks done
marcospb19 opened this issue Oct 6, 2021 · 4 comments
Closed
4 tasks done

Improve [INFO] message when decompressing archives #67

marcospb19 opened this issue Oct 6, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers medium priority pending decision We haven't concluded yet what to do question Further information is requested
Milestone

Comments

@marcospb19
Copy link
Member

marcospb19 commented Oct 6, 2021

image

Suggestions:

  • Should change word "bundle" to "archive".
  • When the destination is '.', output current directory instead.
  • Remove the './' at the beginning of each file, they are pointless: './file'. .
  • The command is called decompress, but here we have "uncompress", seems to be a bit off.
@marcospb19 marcospb19 added enhancement New feature or request question Further information is requested medium priority labels Oct 6, 2021
@marcospb19 marcospb19 changed the title Improve INFO message when uncompressing in current directory Improve [INFO] message when decompressing archives Oct 6, 2021
@marcospb19 marcospb19 added good first issue Good for newcomers pending decision We haven't concluded yet what to do labels Oct 7, 2021
@GabrielSimonetto
Copy link
Collaborator

GabrielSimonetto commented Oct 7, 2021

All of these seem like good changes (:

Maybe we will need to play around a bit on points 2 and 3, maybe just removing the dot on 3 will be a little confusing. We could for example reproduce the dirname we are currently in: Downloads/ouch

I suppose if we took that route we would need to do this even when we had custom destinations for consistency sake

$ pwd
~/Downloads

$ ouch d bolovo.zip -o custom/dir
"Downloads/custom/dir/ouch" extracted. (2.21 MB)

@marcospb19
Copy link
Member Author

For 3, I actually meant the periods at the end of each [INFO] line, but I just realized that the period at the start of the path is redundant too.

@vrmiguel vrmiguel added this to the 0.2.1 milestone Oct 12, 2021
@exoego
Copy link
Contributor

exoego commented Oct 20, 2021

Should change word "bundle" to "archive".

1st seems already resolved.

$ git grep bundle | wc -l
       0

@marcospb19
Copy link
Member Author

marcospb19 commented Oct 21, 2021

Solved by #109 && #117 && #119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers medium priority pending decision We haven't concluded yet what to do question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants