Improve regexp/sort-alternatives rule to add support for string alternatives and v flag
#587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…junctions and v flag
🦋 Changeset detectedLatest commit: b0ddd9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lib/rules/sort-alternatives.ts
Outdated
| } else { | ||
| const words: ReadonlyWord[] = [ | ||
| ...(us.chars.isEmpty ? [] : [[us.chars.ranges[0].min]]), | ||
| ...us.accept.words, |
Collaborator
Owner
Author
There was a problem hiding this comment.
I've added the same fix to this PR. (But there may be conflicts)
Owner
Author
|
@RunDevelopment I fixed getLexicographicallySmallestInConcatenation a little. Could you check if it is the correct fix? |
RunDevelopment
approved these changes
Sep 21, 2023
Collaborator
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you @ota-meshi and sorry for the delay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #572