Update refa & co #568
Merged
Update refa & co #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdf6d26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 5, 2023
ota-meshi
approved these changes
Sep 6, 2023
Owner
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
LGTM! Thank you for great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
refa,regex-ast-analysis, andscslre.There are a lot of changes in both refa and RAA because of the
vflag, so fixing all errors will be fun... I also had to change the semantics of a few common functions in RAA. Noteably,is{Potentially,}{Empty,ZeroLength}and a few others now require a flags argument. (Since we can't assume that a single character class/set is a single character anymore, we have to evaluate the whole thing in some cases, and that requires flags.)This PR is still a work in progress. Since some type errors are caused by the algorithm fundamentally assuming a single character, I will liberally use
// @ts-expect-error -- FIXMEfor now.