Skip to content

tests/kola: Move to tests/kolainst#2116

Merged
openshift-merge-robot merged 1 commit intoostreedev:masterfrom
cgwalters:kolainst
May 27, 2020
Merged

tests/kola: Move to tests/kolainst#2116
openshift-merge-robot merged 1 commit intoostreedev:masterfrom
cgwalters:kolainst

Conversation

@cgwalters
Copy link
Member

Follow the precedent set in coreos/rpm-ostree#2106
and rename the directory, to more clearly move away from the
"uninstalled" test model. Prep for Rust-based tests.

@jlebon
Copy link
Member

jlebon commented May 27, 2020

make[3]: *** No rule to make target 'tests/libtest-core.sh'.  Stop.

Hmm, not sure what's going on here.

Follow the precedent set in coreos/rpm-ostree#2106
and rename the directory, to more clearly move away from the
"uninstalled" test model.  Prep for Rust-based tests.
@cgwalters
Copy link
Member Author

Needed to fix the symlink; the unit tests share this bit.

@jlebon
Copy link
Member

jlebon commented May 27, 2020

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8540998 into ostreedev:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants