tests/kola: Move into tests/kolainst, run installed

[cgwalters]

Switch to the "installed" model introduced by:
coreos/coreos-assembler#1441

It's hard to support running tests both from the srcdir
and installed; in this case because we have a symlink that needs
to be followed, which kola knows how to do from the srcdir
but not when installed. Let's establish a new convention of
tests/kolainst. In our case we follow the symlink manually
for now.

That bit will be cleaned up when we eventually switch entirely
to kola tests.

[jlebon]

Hmm, looking at the CoreOS CI kola output, I see:

=== RUN   ext.i_coreos_rpm-ostree_PR-2106-AKQMSLTU6LDNDFOAKSAOIWSR3RQGYS3VXWEDLEWUPT62GTLTLKFQ.nondestructive

The fact that it has the workspace directory name in its name makes me wonder if it's actually running it from the installed location. Or is that what you'd expect?

[cgwalters]

Or is that what you'd expect?

I think it's likely this: shell basename $$(git rev-parse --show-toplevel))/ - is CI not cloning into a directory named rpm-ostree?

I guess this gets into an interesting "source of truth for naming".

[cgwalters]

Reworked this to just hardcode rpm-ostree and I see

kola --output-dir tmp/kola run --parallel 6 ext.* --blacklist-test fcos.internet --blacklist-test podman.workflow

=== RUN   ext.config

=== RUN   ext.rpm-ostree.nondestructive

--- PASS: ext.config (25.07s)

--- PASS: ext.rpm-ostree.nondestructive (26.07s)

PASS, output in tmp/kola

[jlebon]

Ahh yup, that's much clearer!

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ashcrow,cgwalters,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment