Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic generator for SLSA #2146

Merged
merged 11 commits into from
Aug 17, 2022
Merged

Use generic generator for SLSA #2146

merged 11 commits into from
Aug 17, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Aug 13, 2022 •
edited
Loading

closes #2145

@laurentsimon laurentsimon temporarily deployed to integration-test August 13, 2022 00:47 Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test August 13, 2022 00:48 Inactive
@laurentsimon laurentsimon mentioned this pull request Aug 13, 2022
Closed
@codecov
Copy link

codecov bot commented Aug 13, 2022 •
edited
Loading

Codecov Report

Merging #2146 (61eac62) into main (6001571) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   42.38%   42.38%           
=======================================
  Files          94       94           
  Lines        7825     7825           
=======================================
  Hits         3317     3317           
  Misses       4250     4250           
  Partials      258      258

@github-actions
Copy link

Integration tests success for
[950b8dd]
(https://github.com/ossf/scorecard/actions/runs/2850171036)

@github-actions
Copy link

Integration tests success for
[c7200dd]
(https://github.com/ossf/scorecard/actions/runs/2850173699)

@laurentsimon laurentsimon temporarily deployed to integration-test August 13, 2022 01:21 Inactive
@github-actions
Copy link

Integration tests success for
[b3bbc7c]
(https://github.com/ossf/scorecard/actions/runs/2850178609)

@github-actions
Copy link

Integration tests success for
[4c494ff]
(https://github.com/ossf/scorecard/actions/runs/2850238221)

naveensrinivasan
naveensrinivasan approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

olivekl
olivekl reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments!

docs/checks/internal/checks.yaml Outdated Show resolved Hide resolved
@laurentsimon laurentsimon temporarily deployed to integration-test August 15, 2022 15:08 Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test August 15, 2022 15:12 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) August 15, 2022 15:12
@laurentsimon laurentsimon temporarily deployed to integration-test August 15, 2022 15:14 Inactive
@github-actions
Copy link

Integration tests success for
[e1ecba6]
(https://github.com/ossf/scorecard/actions/runs/2861541096)

@github-actions
Copy link

Integration tests success for
[2d61e05]
(https://github.com/ossf/scorecard/actions/runs/2861570224)

@github-actions
Copy link

Integration tests success for
[c27f8c1]
(https://github.com/ossf/scorecard/actions/runs/2861564515)

@azeemshaikh38
Copy link
Contributor

@laurentsimon lets get this merged in and we can have a new release of Scorecard after that?

@laurentsimon
Copy link
Contributor Author

Yes!

@laurentsimon laurentsimon temporarily deployed to integration-test August 16, 2022 23:22 Inactive
@laurentsimon laurentsimon temporarily deployed to integration-test August 16, 2022 23:42 Inactive
@github-actions
Copy link

Integration tests success for
[3d882d8]
(https://github.com/ossf/scorecard/actions/runs/2871703709)

@github-actions
Copy link

Integration tests success for
[61eac62]
(https://github.com/ossf/scorecard/actions/runs/2871781557)

@laurentsimon laurentsimon merged commit 887facf into ossf:main Aug 17, 2022
@spencerschrock spencerschrock mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivekl olivekl olivekl left review comments

@naveensrinivasan naveensrinivasan naveensrinivasan approved these changes

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLSA provenance available check
4 participants
@laurentsimon @azeemshaikh38 @naveensrinivasan @olivekl