Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLSA provenance available check #2145

Closed
behnazh-w opened this issue Aug 13, 2022 · 6 comments · Fixed by #2146
Closed

SLSA provenance available check #2145

behnazh-w opened this issue Aug 13, 2022 · 6 comments · Fixed by #2146
Labels
kind/bug Something isn't working

Comments

@behnazh-w
Copy link
Contributor

@laurentsimon I have a question about the recent change that checks for .intoto.jsonl extensions in the release assets. With this check, the Scorecard repository itself will not meet the provenance available check, looking at the latest release assets.

I can see that the trusted builder workflow is called here. Would Scorecard report a false positive against itself for SLSA provenance available check?

@behnazh-w behnazh-w added the kind/bug Something isn't working label Aug 13, 2022
@laurentsimon
Copy link
Contributor

laurentsimon commented Aug 13, 2022

You're right. The provenance is stored inside the zip file.. good catch!
Im going to move Scorecard to use the generic generator soon, because the Go builder only supports a single build. Once we have support for multiple builds, we will move back to using the Go builder and release binaries instead of zip files. So the provenance will be stored next to the binaries.

Does this work?

@behnazh-w
Copy link
Contributor Author

behnazh-w commented Aug 13, 2022

Yes, thanks for the quick reply 👍

It would also be good to explicitly document this and encourage people to put the provenance as a release asset to help analysis tools?

@laurentsimon
Copy link
Contributor

laurentsimon commented Aug 13, 2022

See #2146. Let me know what you think for the doc.

@behnazh-w
Copy link
Contributor Author

If SLSA provenances are found for the releases

Because Scorecard looks for the .intoto.jsonl files in the release assets, it would be better to point it out I think, e.g.,

If SLSA provenances are found in the [release assets](https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases)

@laurentsimon
Copy link
Contributor

Updated, PTAL

@behnazh-w
Copy link
Contributor Author

Great. To be consistent, I think the docs/checks.md should change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants