-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last_affected example for clarity #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd like an extra reviewer to also give their opinion.
Not sure if you've seen #35 (I hadn't until today, by happy coincidence). It has a lot of the original thinking behind the introduction of |
@andrewpollock I hadn't read through #35 before! It was interesting reading, but I'm a little wary of putting too much of that history in the schema. I feel like it may have the tendency to prompt more questions than it would answer and that section is already kind of long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! just some minor comments
Signed-off-by: Hayley Denbraver <[email protected]>
Signed-off-by: Hayley Denbraver <[email protected]>
Signed-off-by: Hayley Denbraver <[email protected]>
Thanks @oliverchang ! I have addressed the comments. Let me know if there are any more changes. |
I agree. |
Hopefully wraps up #150 and #146
View rendered example here.
Changes were also made to the affected.ranges.events fields to bring the formatting into line with the rest of the document. Fields were being rendered like this:
"last_affected"
wherelast_affected
is preferred.