Add comment about last_affected usage in evaluation pseudocode
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcono1234 <[email protected]>
|
Hey, thanks for this PR! https://ossf.github.io/osv-schema/#examples might be a better place for this, and it's currently lacking some examples for CC @hayleycd who is helping us with this. |
|
I agree with @oliverchang that this is better resolved in an example, but I appreciate your interest in the issue. I just opened #174 if you want to take a look. |
|
Thanks for taking care of this and writing such an extensive example! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves partially #150
I thought this might be useful, but on the other hand I am not completely sure if this is really needed and it might just increase confusion.
So no worries if you reject this PR.