Skip to content
This repository was archived by the owner on Jul 22, 2021. It is now read-only.

Fix/finish duration#185

Closed
aaronchongth wants to merge 8 commits intofeature/task_plannerfrom
fix/finish_duration
Closed

Fix/finish duration#185
aaronchongth wants to merge 8 commits intofeature/task_plannerfrom
fix/finish_duration

Conversation

@aaronchongth
Copy link
Copy Markdown
Contributor

@aaronchongth aaronchongth commented Oct 7, 2020

  • Removed all time related default arguments, especially those using std::chrono::steady_clock::now()
  • Changed to using finish_duration instead of finish_time, so that everything is handled relatively to the planning start time
  • Added arguments for relative start time to all relevant methods and objects
  • Removed default constructor for agv::State
  • Modified tests to work as before
  • Throws exception when invalid battery state of charge values are passed.
  • Some documentation

@aaronchongth aaronchongth requested a review from Yadunund October 7, 2020 09:58
…ust be between 0.0 and 1.0

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
… hold onto location and time

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Copy link
Copy Markdown
Contributor Author

Closing in favour of #188

@aaronchongth aaronchongth deleted the fix/finish_duration branch October 12, 2020 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant