[ROS] Crystal

[ruffsl]

Support for ROS2 Crystal
ros2/ros2#529

TODO list upstreaming to Docker Hub Official Library:

• Update docker templates for ROS2:
  • See Improve ROS2 template to match ROS1 docker_templates#46
• Update PR to version pin release
  • Set version in template to empty to force remote lookup
• Create Upstream Documentation PR
  • https://github.com/docker-library/docs/blob/master/README.md
  • See [ROS] Add Official Docker image for ROS2 docker-library/docs#1381
• Create Upstream Library PR
  • https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md
  • See [ROS] Add Official Docker image for ROS2 docker-library/official-images#5183

[ruffsl]

@sloretz , I added some questions. Let me know if find any answers.

[nuclearsandwich]

We should set up these images to use the new ROS2 main repository. The documentation hasn't switched over yet but the repositories are live. ros2/ros2_documentation#59

In the templates an $ID variable is used for main or testing. That logic needs to be updated to select between http://packages.ros.org/ros2/ubuntu and http://packages.ros.org/ros2-testing/ubuntu

[ruffsl]

We should set up these images to use the new ROS2 main repository. The documentation hasn't switched over yet but the repositories are live. ros2/ros2_documentation#59

@nuclearsandwich , please see 1e3e24d and osrf/docker_templates@fcce956

In the templates an $ID variable is used for main or testing. That logic needs to be updated to select between http://packages.ros.org/ros2/ubuntu and http://packages.ros.org/ros2-testing/ubuntu

I'll try and expand the template to account for this later on, though it shouldn't block anything here.

[ruffsl]

@sloretz @tfoote and @nuclearsandwich , I've modified the PR in accordance with the existing ROS repo in the docker library. It now shares the same entrypoint and repo structure. I've also update the upstream PR to the library to point to the latest state of this PR. Let me know if you have any more suggestions or not.

Update: I've also merged the docker directories into the common ros folder to share the same manifest.

[sloretz]

It looks like an exception is raised on my machine when creating the dockerfiles for ros/source/ros2. Is there a different branch of osrf/docker_templates I should be using?

$ ./create_dockerfiles.py dir -d ./source/ros2
RuntimeError processing template 'docker_images/create_ros2_source_image.Dockerfile.em'
Traceback (most recent call last):
  File "./create_dockerfiles.py", line 70, in <module>
    main()
  File "./create_dockerfiles.py", line 67, in main
    create_files(data)
  File "/home/sloretz/projects/osrf-docker/env/lib/python3.5/site-packages/docker_templates-0.0.1-py3.5.egg/docker_templates/create.py", line 45, in create_files
    create_dockerfile(template_name, data, dockerfile_dir, verbose)
  File "/home/sloretz/projects/osrf-docker/env/lib/python3.5/site-packages/ros_buildfarm-2.0.1-py3.5.egg/ros_buildfarm/templates/__init__.py", line 162, in create_dockerfile
    content = expand_template(template_name, data)
  File "/home/sloretz/projects/osrf-docker/env/lib/python3.5/site-packages/ros_buildfarm-2.0.1-py3.5.egg/ros_buildfarm/templates/__init__.py", line 79, in expand_template
    template_path = get_template_path(template_name)
  File "/home/sloretz/projects/osrf-docker/env/lib/python3.5/site-packages/ros_buildfarm-2.0.1-py3.5.egg/ros_buildfarm/templates/__init__.py", line 40, in get_template_path
    raise RuntimeError("Failed to find template '%s'" % template_name)
RuntimeError: Failed to find template 'docker_images/create_ros2_source_image.Dockerfile.em'

[ruffsl]

The ROS 2 source docker file hasn't been generated for some time. I'm not surprised something broke, but this is not a blocker for the office images. Looks like the path to the em file just needs to be updated to reflect the directory restructure in the template package. Once I fix this, is there any other last changes to the official Docker images? Otherwise continue with the upstream process.

[sloretz]

Once I fix this, is there any other last changes to the official Docker images? Otherwise continue with the upstream process.

No changes; it looks good to me.