Update log4j to 2.17.1 #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, move classes using log4j to slf4j. Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Collaborator
Author
|
Note: We can use dependency substitution to use the osgeo -norce version instead of excluding osgeo. |
This was referenced Dec 16, 2021
Bentleysb
reviewed
Dec 17, 2021
Collaborator
Bentleysb
left a comment
Bentleysb
left a comment
There was a problem hiding this comment.
This looks great. Thanks for working to update this. Have you done any test runs with these changes, local or remote?
Collaborator
|
log4j 2.16.0 creates another vulnerability (CVE-2021-45105). So we need to upgrade to 2.17.0. Edit - now we need it updated to 2.17.1 |
Also update Jacoco, Junit, and SQLite, all of which should have no source compatibility issues. Signed-off-by: Taylor Smock <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Collaborator
Author
I have done a local run with some additional dependency updates ( |
Collaborator
|
I took tsmock's branch and executed on AWS EMR and it looked like it was working correctly. |
Bentleysb
approved these changes
Jan 4, 2022
rheatreena
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, move classes using log4j to slf4j.
This should have no effect on runtime logging.
See also