-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The big renaming... #1826
Comments
I understand that this is to be addressed at the retreat in a few weeks. Here are two points in the toric universe, that should be considered:
|
Torus-factor is illegal I think...
The other one is e.g British Vs American spelling. Supporting both is fine,
but tab completion cannot cope...
…On Thu, 9 Feb 2023, 18:05 Martin Bies, ***@***.***> wrote:
I understand that this is to be addressed at the retreat in a few weeks.
Here are two points in the toric universe, that should be considered:
- Provide snake_case for all functions but types. (This is how I
understand the first bullet point in the OSCAR style guide:
https://docs.oscar-system.org/stable/DeveloperDocumentation/styleguide/
.)
- I wonder about functions whose name contains torusinvariant or
torusfactor. Our standard reference (the book by Cox, Little, Schenk)
spells these as "torus-invariant" and "torus factor" respectively. Does
torusinvariant -> torus-invariant and has_torusfactor ->
has_torus_factor, respectively, makes sense? ***@***.***
<https://github.com/lkastner> )
—
Reply to this email directly, view it on GitHub
<#1826 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36CV4ALHQSMKNUSWM3QOTWWUPWTANCNFSM6AAAAAAS7CMP6U>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Ok. This sounds like we should leave as is. Was just curious to hear what people think. |
Here is another point - originally raised by @afkafkafk13: |julia> C = positive_hull([1 0; 0 1])
A polyhedral cone in ambient dimension 2
|julia> antv = AffineNormalToricVariety(C)
A normal, affine toric variety
|julia> affine_toric_scheme = ToricSpec(antv)
Spec of an affine toric variety with cone spanned by RayVector{fmpq}[[1, 0], [0, 1]] The suggestion by @afkafkafk13 was to remove the "A" in the output printed by the first two commands, i.e. the example should eventually look like: |julia> C = positive_hull([1 0; 0 1])
Polyhedral cone in ambient dimension 2
|julia> antv = AffineNormalToricVariety(C)
Normal, affine toric variety
|julia> affine_toric_scheme = ToricSpec(antv)
Spec of an affine toric variety with cone spanned by RayVector{fmpq}[[1, 0], [0, 1]] I briefly discussed with @fieker, who confirms that removal of the "A" is desired. The necessary change would affect the toric geometry and polyhedral geometry and seems well suited to be integrated into the big renaming. Hence, I post this here. I have not checked all of OSCAR thoroughly to see what areas use which "A" convention. However, a first superficial check showed that rings, groups, schemes do not print the "A". So those areas will most likely not require a change. |
The following might also be related/could be closed once the big renaming is complete: #1714 |
Some more names that I noted: |
@simonbrandhorst I am not 100% what you mean with |
Since it is lower case, I would expect some kind of method. |
That's a good argument then. Not sure what kind of precedent you are looking for? I guess |
Returning a "generator" of |
I think just returning |
Added in Nemocas/Nemo.jl#1547 |
What about more or less weirdly types in Hecke that currently do not fit into our naming scheme, e.g. NfRelNS, GrpAbFinGen or AlgMat? |
I plan to rename |
The hackmd in #1826 (comment) mentiones a change like |
We decided back then to leave it at |
It seems we never made an issue for this (or at least I can't find it...) and since @HereAround asked me about it to day:
There are ton of functions and types we think we should rename. We meant to do that for a long time now... Part of the problem is that in not all cases do we know what we want to rename to, i.e.: decisions need to be made. But that we can (and should!) do. Then "just" someone has to take care of it.
Note: I don't think we should strive to do "everything at once". Instead, we can start cleaning up things immediately whenever we can. But for some things, clearly we should first have the "big picture" that we aim for settled.
UPDATE: while we had a workshop where we did a ton of renaming, this is still not complete. Here is a list of more suggestions which we might want to consider:
more general renaming:
short names that need longer alias (or be renamed outright?)
number_of_connected_components
?what about
sylow_subgroup
)The text was updated successfully, but these errors were encountered: