Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conventions and strategies throughout OSCAR #1714

Open
HereAround opened this issue Nov 11, 2022 · 5 comments
Open

Naming conventions and strategies throughout OSCAR #1714

HereAround opened this issue Nov 11, 2022 · 5 comments

Comments

@HereAround
Copy link
Member

For consistency and user friendliness across the many different areas of OSCAR, it might be good to discuss and ideally agree on the following.

Naming conventions:

  • quotient_ring vs. quo,
  • residue_ring vs. quo,
  • subscheme vs. sub or closed_sub,
  • hypersurface_complement vs. open_sub,
  • ambient_affine_space vs. ambient_space (is affine not implicitly clear?)
  • ...

Strategies:

  • specifying many variable names (multivariate polynomial ring, graded ring, finitely presented groups, schemes, toric varieties, ...)
  • ...
@thofma
Copy link
Collaborator

thofma commented Nov 11, 2022

I don't think the soon to be introduced quotient_ring has any relation to quo, since it takes only one argument (the ring).

@fieker
Copy link
Contributor

fieker commented Nov 11, 2022 via email

@afkafkafk13
Copy link
Collaborator

I think that we should have this discussion in person -- not with erveryone typing in a github issue (and maybe only sum up the results here afterwards for later reference).

To your examples above just one remark:
A hypersurface_complement of an affine variety is much more specific than a Zariski open subset of it; only the former carries the structure of an affine variety itself.

@fingolfin
Copy link
Member

Another one: complement_of_ideal -> complement maybe?

@HechtiDerLachs
Copy link
Collaborator

Some first steps have been taken in #1738 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants