osbuild-dnf-json-tests: use distrofactory to get centos-9#4782
Merged
mvo5 merged 1 commit intoosbuild:mainfrom Jul 23, 2025
Merged
osbuild-dnf-json-tests: use distrofactory to get centos-9#4782mvo5 merged 1 commit intoosbuild:mainfrom
distrofactory to get centos-9#4782mvo5 merged 1 commit intoosbuild:mainfrom
Conversation
mvo5
requested review from
achilleas-k,
croissanne and
thozza
and removed request for
a team
lzap
approved these changes
Jul 22, 2025
The test was importing `distro/rhel/rhel9` directly instead of using the `distrofactory`. This is problematic as the go module for `rhel9` is going away. This commit fixes this by going via the `distrofactory` which will keep working.
achilleas-k
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was importing
distro/rhel/rhel9directly instead of using thedistrofactory. This is problematic as the go module forrhel9is going away. This commit fixes this by going via thedistrofactorywhich will keep working.Needed for osbuild/images#1645