Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHEL 9.3.0] deps: update osbuild/images to v0.3.0-r9.3.2 #3685

Merged
merged 3 commits into from
Sep 19, 2023
Merged

[RHEL 9.3.0] deps: update osbuild/images to v0.3.0-r9.3.2 #3685

merged 3 commits into from
Sep 19, 2023

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Sep 15, 2023 •
edited
Loading

Update images dependency to pull in change to minimal raw images [1] for release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].

[1] osbuild/images#163
[2] osbuild/images#166

@achilleas-k achilleas-k added the WIP+test Work in progress but run Gitlab CI. label Sep 15, 2023
schutzbot
schutzbot reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD eea4dc3 with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5099071187/artifacts/browse

@achilleas-k achilleas-k changed the title WIP: update osbuild/images to RHEL 9.3.0 branch deps: update osbuild/images to v0.3.0-r9.3 Sep 15, 2023
schutzbot
schutzbot reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD eea4dc3 with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5099071706/artifacts/browse

@achilleas-k achilleas-k marked this pull request as ready for review September 15, 2023 14:20
@achilleas-k achilleas-k removed the WIP+test Work in progress but run Gitlab CI. label Sep 15, 2023
schutzbot
schutzbot reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD e23322a with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5100436022/artifacts/browse

schutzbot
schutzbot reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD e23322a with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5101076712/artifacts/browse

@achilleas-k achilleas-k changed the title deps: update osbuild/images to v0.3.0-r9.3 [RHEL 9.3.0] deps: update osbuild/images to v0.3.0-r9.3 Sep 18, 2023
@achilleas-k achilleas-k force-pushed the rhel-9.3.0 branch 2 times, most recently from c7a2624 to 4fbf4bf Compare September 18, 2023 18:47
@achilleas-k
deps: update osbuild/images to v0.3.0-r9.3.2
538ac18 
Update images dependency to pull in change to minimal raw images [1] for
release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].

[1] osbuild/images#163
[2] osbuild/images#166
@achilleas-k
github: disable caching for golangci-lint-action
1d5c281
@achilleas-k achilleas-k changed the title [RHEL 9.3.0] deps: update osbuild/images to v0.3.0-r9.3 [RHEL 9.3.0] deps: update osbuild/images to v0.3.0-r9.3.2 Sep 18, 2023
schutzbot
schutzbot reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 1d5c281 with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5113886436/artifacts/browse

schutzbot
schutzbot reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 1d5c281 with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5113887070/artifacts/browse

@henrywang
Copy link
Member

henrywang commented Sep 19, 2023 •
edited
Loading

Tests / edge-simplified-9 is due to bug https://issues.redhat.com/browse/RHEL-4992. I have workaround PR #3690

@achilleas-k
Copy link
Member Author

Tests / edge-simplified-9 is due to bug https://issues.redhat.com/browse/RHEL-4992. I have workaround PR #3690

Thank you! I cherry picked the commit over.

schutzbot
schutzbot reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 56e69e9 with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5118598970/artifacts/browse

schutzbot
schutzbot reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 56e69e9 with the rhel-9.3.0 merge-base 567fb68). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5120848587/artifacts/browse

@henrywang
Copy link
Member

@achilleas-k All green now.

@supakeen supakeen merged commit 23a59ea into osbuild:rhel-9.3.0 Sep 19, 2023
70 checks passed
@achilleas-k achilleas-k deleted the rhel-9.3.0 branch September 19, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

@supakeen supakeen supakeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achilleas-k @henrywang @supakeen @schutzbot