Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro: fix kernel options for Fedora Azure image #166

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Sep 18, 2023

During rebase of 3d36490, this change was missed due to 3d8388e.

During rebase of 3d36490, this change
was missed due to 3d8388e.
Copy link
Contributor

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@achilleas-k achilleas-k enabled auto-merge (rebase) September 18, 2023 17:37
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why we need a Fedora-related change in a RHEL branch, but it also shouldn't do any harm, and you have my full trust as always. :)

@kingsleyzissou
Copy link
Contributor

I don't fully understand why we need a Fedora-related change in a RHEL branch, but it also shouldn't do any harm, and you have my full trust as always. :)

I believe it's because #163 contained some of those changes already

@achilleas-k achilleas-k merged commit 21f579f into osbuild:rhel-9.3.0 Sep 18, 2023
9 checks passed
@achilleas-k
Copy link
Member Author

I don't fully understand why we need a Fedora-related change in a RHEL branch, but it also shouldn't do any harm, and you have my full trust as always. :)

I considered disabling the tests in the RHEL branch in osbuild-composer but decided fixing the issue would be better, even if a bit pointless.

@achilleas-k achilleas-k deleted the rhel-9.3.0 branch September 18, 2023 18:08
achilleas-k added a commit to achilleas-k/osbuild-composer that referenced this pull request Sep 18, 2023
Update images dependency to pull in change to minimal raw images [1] for
release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].

[1] osbuild/images#163
[2] osbuild/images#166
achilleas-k added a commit to achilleas-k/osbuild-composer that referenced this pull request Sep 18, 2023
Update images dependency to pull in change to minimal raw images [1] for
release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].

[1] osbuild/images#163
[2] osbuild/images#166
achilleas-k added a commit to achilleas-k/osbuild-composer that referenced this pull request Sep 18, 2023
Update images dependency to pull in change to minimal raw images [1] for
release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].

[1] osbuild/images#163
[2] osbuild/images#166
supakeen pushed a commit to osbuild/osbuild-composer that referenced this pull request Sep 19, 2023
Update images dependency to pull in change to minimal raw images [1] for
release into RHEL 9.3.0.
Includes fix for Azure image kernel options [2].

[1] osbuild/images#163
[2] osbuild/images#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants