Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce partitioning modes #3222

Closed
wants to merge 4 commits into from

Conversation

ondrejbudai
Copy link
Member

A very early PR for COMPOSER-1882 (internal only link, sorry!).

The new partitioning modes are:

  • auto-lvm (the default, keeps the current behaviour)
  • lvm (the image uses LVM even without extra partitions)
  • raw (the image uses raw partitioning even with extra partitions)

Currently, they are only exposed in the cloud API.

To-do:

  • discuss whether my changes in internal/disk are sane
  • support in the Weldr API
  • documentation for Weldr (in osbuild/guides)
  • tests

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@ondrejbudai ondrejbudai added the WIP+test Work in progress but run Gitlab CI. label Jan 17, 2023
@ondrejbudai ondrejbudai marked this pull request as draft January 17, 2023 20:39
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 8, 2023
@bcl bcl removed the Stale label Sep 11, 2023
@bcl
Copy link
Contributor

bcl commented Sep 11, 2023

Removed stale, I'm working on a variant of this and will keep this branch for reference.

@bcl bcl mentioned this pull request Oct 5, 2023
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 12, 2023
@bcl bcl removed the Stale label Oct 12, 2023
@bcl
Copy link
Contributor

bcl commented Oct 12, 2023

#3723 and osbuild/images#189 are the current version of this.

@bcl bcl closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP+test Work in progress but run Gitlab CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants