Partition mode #189
Merged
Partition mode #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
force-pushed
the
main-partition-mode
branch
2 times, most recently
from
9a973fb
to
b568847
Compare
|
This is ready to review. It is currently vendored into osbuild/osbuild-composer#3723 to see if the full suite of tests will pass with it. It's slightly different from the original PR, I decided to make an empty/missing PartitioningMode use DefaultPartitioningMode so that the string conversions are nicer to read. The fact that Default results in AutoLVM is enforced in this code and nowhere else. eg. If the osbuild-composer code gets an empty entry it calls this code with DefaultPartitioningMode instead of AutoLVM so that we have a single place deciding what the default actually is. |
3 tasks
|
Awesome, @bcl! I will wait for Achilleas to return, I don't feel comfortable giving this an approval, considering that I wrote most of these changes. :) |
bcl
force-pushed
the
main-partition-mode
branch
from
b568847
to
57a49df
Compare
achilleas-k
reviewed
Oct 12, 2023
7 tasks
bcl
force-pushed
the
main-partition-mode
branch
from
57a49df
to
5f20973
Compare
pt.features() now returns a struct with flags set for each feature used in the members of the partition table. Also adds a test for the new function. Based on PR #3222
This adds support for AutoLVM mode which uses LVM when there are 1 or more extra mountpoints, LVM mode which always uses LVM, and Raw mode which always uses raw partitions. This also removes a panic from ensureLVM, returning an error instead. There are cases where the mode can conflict with the selected partition table. Also includes a new test for always using LVM.
And use it in the distro's getPartitionTable. TODO Logic about that combination of things is or is not supported needs a more central location than embedded in the functions.
bcl
force-pushed
the
main-partition-mode
branch
from
5f20973
to
117134d
Compare
achilleas-k
approved these changes
Oct 12, 2023
|
THANKS! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a port of osbuild/osbuild-composer#3222 to images. I think this is complete, but I need to clean up the osbuild-composer part first so marking this as a draft for now.