Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osbuild: include context in skopeo error messages #289

Merged
merged 2 commits into from
Dec 4, 2023
Merged

osbuild: include context in skopeo error messages #289

merged 2 commits into from
Dec 4, 2023

Commits on Dec 4, 2023

  1. internal: add new interla/assertx/PanicsWithErrorRegexp 

    This adds a new internal package with `testify/assert` extensions.
It contains the new 'PanicsWithErrorRegexp()` helper that can
be removed once upstream stretchr/testify#1304
is fixed (or we contributed this back).

It could not be added to `internal/test` as it would have created
cyclic dependencies when importing from `pkg/osbuild`.
    @mvo5
    mvo5 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    afd854d View commit details
    Browse the repository at this point in the history

  2. osbuild: include context in skopedo error messages 

    When trying to create enough data for a full pipeline run for
osbuild#287 I struggled a bit
because it was not clear which items where faulty.

This commit adds more context to the errors. It uses the new
`assertx.PanicsWithErrorRegexp` that is needed because of
stretchr/testify#1304
(until fixed or contributed back).
    @mvo5
    mvo5 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4f36c1d View commit details
    Browse the repository at this point in the history