osbuild: include context in skopeo error messages #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
skopedo-more-err-context
branch
2 times, most recently
from
8adffb5
to
b8cf781
Compare
bcl
reviewed
Nov 30, 2023
achilleas-k
reviewed
Dec 1, 2023
achilleas-k
changed the title
|
Fixed a typo in the PR name. Hope you don't mind :) |
This adds a new internal package with `testify/assert` extensions. It contains the new 'PanicsWithErrorRegexp()` helper that can be removed once upstream stretchr/testify#1304 is fixed (or we contributed this back). It could not be added to `internal/test` as it would have created cyclic dependencies when importing from `pkg/osbuild`.
When trying to create enough data for a full pipeline run for osbuild#287 I struggled a bit because it was not clear which items where faulty. This commit adds more context to the errors. It uses the new `assertx.PanicsWithErrorRegexp` that is needed because of stretchr/testify#1304 (until fixed or contributed back).
mvo5
force-pushed
the
skopedo-more-err-context
branch
from
b8cf781
to
4f36c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to create enough data for a full pipeline run for #287 I struggled a bit because it was not clear which items where faulty.
This commit adds more context to the errors. Sadly I had to implement
assertPanicsWithErrorRegexpbecause of stretchr/testify#1304I can contribute it upstream but for that it needs some tests around it first :)