many: iso configuration and customization (HMS-9963) #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
force-pushed
the
moderniso-isocustomizations
branch
2 times, most recently
from
0d86fe9 to
d28419a
Compare
lzap
reviewed
Jan 2, 2026
supakeen
changed the title
supakeen
force-pushed
the
moderniso-isocustomizations
branch
from
d28419a to
87feb3b
Compare
supakeen
force-pushed
the
moderniso-isocustomizations
branch
2 times, most recently
from
3200e9e to
5c255c7
Compare
Member
Author
supakeen
force-pushed
the
moderniso-isocustomizations
branch
from
5c255c7 to
7a9c562
Compare
Member
Author
|
Ok, this has now been rebased and is ready for review. |
achilleas-k
approved these changes
Jan 6, 2026
Member
achilleas-k
left a comment
achilleas-k
left a comment
There was a problem hiding this comment.
LGTM. I agree with this split, it makes sense to me.
Small issue with the preparer string though (which we can decide on and change later).
lzap
approved these changes
Jan 7, 2026
Contributor
lzap
left a comment
lzap
left a comment
There was a problem hiding this comment.
Well if some CDROM emulator code in iDRAC won't crunch this, well, we will find out I guess :-) Probably this is fine.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
Author
|
Sadly re-adding this to the queue won't make it pass, the check @achilleas-k added in 44d2f85 is pretty consistently failing on a bunch of image types showing that the configuration file is apparently not being copied. |
supakeen
force-pushed
the
moderniso-isocustomizations
branch
from
7a9c562 to
58bcb28
Compare
Require a newer version of osbuild so we can make use of additional added stage options. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Allow setting the newly added [1] additional fields for the xorrisofs stage in the osbuild stage. [1]: osbuild/osbuild#2269 Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
This includes support for setting the new ISO customizations. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Introduce a customizations struct for the ISO pipeline generator, consistent with how we manage customizations for the OS, and installer pipeline generators. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Add the ISO customizations to all installers and pass them along to the ISO pipeline generator. Note that these customizations are not yet filled in this is just the structural change. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Create a new configuration struct that determines options for ISO media. This follows the same idea as we use for `image_config` (which likely should be split out more) and `installer_config`. Also introduce the function that will in the future handle merging of the `iso_config` and any customization values and apply this function to each image that includes `ISOCustomizations`. Note that nothing here is really used yet still; this is only setup code to be able to use the `ISOCustomizations` in the next commits. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Move the ISO label out of the installer customizations and into the ISO customizations as it only applies to manifest pipelines that are packed into ISOs, not to all potential installers. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
The root filesystem type for ISOs only applies to ISOs. Move it into the ISO customizations instead of installer. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
The boot type for ISOs only applies to ISOs. Move it into the ISO customizations instead of installer. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Instead of passing separate fields into the xorrisofs stage option function pass all the customizations so they're more easily expanded. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Allow the configuration of additional metadata fields in the YAML for the ISO. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Override any customization fields with their blueprint values if they are set. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
Fill in the preparer and publisher fields for Fedora ISOs by default. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
force-pushed
the
moderniso-isocustomizations
branch
from
58bcb28 to
4a3076f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty mechanical PR right up until the last two or three commits.
InstallerCustomizationsandInstallerConfigby introducingISOCustomizationsandISOConfig. This unmuddies the waters a bit for options that apply only to installer(s) (really; mostly Anaconda) and the options that apply only to the assembling of the ISO artifact itself.After that it implements the new options for the xorrisofs stage, adds them to the Fedora installers and implements the overriding of these fields through blueprints. The last bit will be necessary to produce these ISOs in Koji as this field is (normally) controlled through Pungi.